[UnifiedDocViewer] Move Discover doc viewer into plugin/package

[lukasolson]

Summary

Replaces #154012.

Moves the Discover doc viewer component into a new plugin/package, @kbn/unified-doc-viewer and @kbn/unified-doc-viewer-plugin.

Checklist

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[davismcphee]

The latest changes look good! I like that we're abstracting away the services and registry, and this API feels more in line with some of the other AnalystXP components. I also tested locally again and things still seem to be working as expected. I just have a couple of minor comments on the code.

[lukasolson]

Sorry @walterra, I didn't mean to re-request your review, clicked on accident!

[davismcphee]

Thanks for the last bit of cleanup! I did a final round of testing including Discover, Surrounding Docs, and Dashboard with both the new data grid and the legacy one and confirmed everything seems to be working as expected. Thanks for all the great work on this, LGTM 👍

[kertal]

Looking great 🥳 Thx so much for bringing this over the finishing line! Just left some minor remarks having another look at the code

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: ebfad2e
• Interpreting CI Failures
• Storybooks Preview

Failed CI Steps

• Serverless Observability Tests
• Serverless Observability Examples Tests
• Serverless Security Examples Tests
• Serverless Security Cypress Tests #2
• Serverless Security Investigations Cypress Tests #1
• Serverless Security Explore Cypress Tests #2

Test Failures

• [job] [logs] Serverless Observability Tests / serverless common UI home page has project header
• [job] [logs] Serverless Observability Examples Tests / serverless examples UI Discover customization examples Customizations "before all" hook for "Top nav"
• [job] [logs] Serverless Security Examples Tests / serverless examples UI Search examples handling warnings with search source fetch shows shard failure warning notifications by default

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
canvas	1235	1237	+2
dataVisualizer	554	567	+13
discover	629	598	-31
savedSearch	47	49	+2
unifiedDocViewer	-	107	+107
total			+93

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/discover-utils	34	38	+4
@kbn/unified-doc-viewer	-	7	+7
@kbn/unified-field-list	277	275	-2
discover	72	71	-1
unifiedDocViewer	-	10	+10
total			+18

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dataVisualizer	606.3KB	606.1KB	-220.0B
discover	564.3KB	504.0KB	-60.3KB
eventAnnotation	177.4KB	177.1KB	-221.0B
lens	1.4MB	1.4MB	-446.0B
unifiedDocViewer	-	56.3KB	+56.3KB
total			-4.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
@kbn/unified-doc-viewer	-	5	+5
discover	17	15	-2
unifiedDocViewer	-	3	+3
total			+6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
discover	31.5KB	29.6KB	-1.9KB
unifiedDocViewer	-	9.8KB	+9.8KB
total			+7.9KB

Unknown metric groups

API count

id	before	after	diff
@kbn/discover-utils	59	65	+6
@kbn/unified-doc-viewer	-	10	+10
@kbn/unified-field-list	306	302	-4
discover	99	98	-1
unifiedDocViewer	-	13	+13
total			+24

async chunk count

id	before	after	diff
discover	21	17	-4
unifiedDocViewer	-	6	+6
total			+2

ESLint disabled line counts

id	before	after	diff
discover	43	32	-11
unifiedDocViewer	-	8	+8
total			-3

Total ESLint disabled count

id	before	after	diff
discover	43	32	-11
unifiedDocViewer	-	8	+8
total			-3

History

• 💔 Build #155332 failed 0de986a
• 💛 Build #155018 was flaky 5659b3a
• 💔 Build #154990 failed 5335161
• 💚 Build #154706 succeeded 47b67f7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

[kibanamachine]

💔 All backports failed

Status	Branch	Result
❌	8.10	Backport failed because of merge conflicts You might need to backport the following PRs to 8.10: - [Security Solution] Expandable flyout - update copy writing (#164929)

Manual backport

To create the backport manually run:

node scripts/backport --pr 162847

Questions ?

Please refer to the Backport tool documentation