Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] expandable flyout - prevalence data is calculated from 30d to now #162791

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

PhilippeOberti
Copy link
Contributor

Summary

This previous PRs added the prevalence summary and the prevalence detail components to the expandable flyout right and left sections respectively.

This PR modifies the way the data is queried: instead of fetching some prevalence data. It was previously using a dynamic from/to time interval that was retrieved from timeline if timeline is active, or from the KQL bar. We're now retrieving prevalence information for the last 30 days (similar to the threat intelligence data). Changes have been made to the following hooks:

  • useFetchFieldValuePairByEventType that retrieves all the unique hosts in the environment that have the field/value pair
  • useFetchFieldValuePairWithAggregation that retrieves all the unique documents for the aggregationField in the environment that have the field/value pair

This PR shouldn't introduce any visual changes.

A follow up PR will add a datetime picker to the left section, to allow users to select a specific time range for the prevalence table.

https://github.com/elastic/security-team/issues/7014

Checklist

Delete any items that are not applicable to this PR.

@PhilippeOberti PhilippeOberti requested a review from a team as a code owner July 31, 2023 12:21
@PhilippeOberti PhilippeOberti force-pushed the expanded-flyout-7014 branch 4 times, most recently from 6ecae1b to 678f207 Compare August 1, 2023 08:13
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner August 1, 2023 08:13
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.6MB 15.6MB -1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me! My only comment is that it's not obvious prevalence is calculated -30d to now. I know the date picker is down the line. It will still be helpful to have it spelled out like threat intelligence, or have an info icon to document that.

image

The inspection icon could be another option. It is widely used in alerts page

image

@PhilippeOberti
Copy link
Contributor Author

Implementation looks good to me! My only comment is that it's not obvious prevalence is calculated -30d to now. I know the date picker is down the line. It will still be helpful to have it spelled out like threat intelligence, or have an info icon to document that.

@christineweng after discussing with Paul, if you're ok with it, I'm thinking about merging the PR as is and I will add the datetime picker after.

@PhilippeOberti PhilippeOberti merged commit f9f2d37 into main Aug 8, 2023
@PhilippeOberti PhilippeOberti deleted the expanded-flyout-7014 branch August 8, 2023 21:38
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants