[Serverless] Change default value of enabling config of security apps #162187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Team:Kibana Management
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
pgayvallet
approved these changes
Jul 20, 2023
azasypkin
approved these changes
Jul 20, 2023
Comment on lines
+50
to
+53
| # Disable UI of security management plugins | ||
| xpack.security.ui.userManagementEnabled: false | ||
| xpack.security.ui.roleManagementEnabled: false | ||
| xpack.security.ui.roleMappingManagementEnabled: false |
There was a problem hiding this comment.
note: fwiw, we're going to drop these flags completely soon and rely on a buildFlavor internally instead (#161930).
There was a problem hiding this comment.
Okay, thanks for the heads-up @azasypkin! Would you like me to change this PR so that it uses build flavor instead?
There was a problem hiding this comment.
Would you like me to change this PR so that it uses build flavor instead?
Sorry, missed that part. No worries, we'll make this change in a separate PR (we need to disable both APIs and UIs).
kibanamachine
added
v8.10.0
backport:skip
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…elastic#162187) This is a follow-up to elastic#160671, where the Management plugins were disabled using `contextRef`. The configs for disabling the UI of the security management plugins were added in elastic#158186. In this PR, they are changed so that they follow the same convention for disabling the Management plugins - setting the default values of the configs to `true` and explicitly setting them to `false` in the `serverless.yml` file. This way, we have a clear view in `serverless.yml` of all plugins/functionalities that have been disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #160671, where the Management plugins were disabled using
contextRef.The configs for disabling the UI of the security management plugins were added in #158186. In this PR, they are changed so that they follow the same convention for disabling the Management plugins - setting the default values of the configs to
trueand explicitly setting them tofalsein theserverless.ymlfile. This way, we have a clear view inserverless.ymlof all plugins/functionalities that have been disabled.