Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable API protection in serverless #162149

Merged
merged 12 commits into from
Aug 4, 2023
Merged

Enable API protection in serverless #162149

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
35f9976
enable API protection in serverless
TinaHeiligers Jul 18, 2023
ea4f86c
Merge branch 'main' into TinaHeiligers-patch-3
jloleysens Jul 26, 2023
1254b82
Merge branch 'main' into TinaHeiligers-patch-3
kibanamachine Jul 27, 2023
d70f76d
Merge branch 'main' into TinaHeiligers-patch-3
kibanamachine Jul 27, 2023
86db734
Merge branch 'main' into TinaHeiligers-patch-3
kibanamachine Jul 28, 2023
757186c
Merge branch 'main' into TinaHeiligers-patch-3
jloleysens Aug 1, 2023
f57b71d
Merge branch 'main' into TinaHeiligers-patch-3
jloleysens Aug 1, 2023
c07f854
Merge branch 'main' into TinaHeiligers-patch-3
kibanamachine Aug 2, 2023
548af6a
Merge branch 'main' into TinaHeiligers-patch-3
kibanamachine Aug 2, 2023
6f28f2a
Merge branch 'main' into TinaHeiligers-patch-3
kibanamachine Aug 3, 2023
8e39668
Merge branch 'main' into TinaHeiligers-patch-3
kibanamachine Aug 4, 2023
6334d7b
Merge branch 'main' into TinaHeiligers-patch-3
kibanamachine Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ xpack.security.ui.roleManagementEnabled: false
xpack.security.ui.roleMappingManagementEnabled: false

# Enforce restring access to internal APIs see https://github.com/elastic/kibana/issues/151940
# server.restrictInternalApis: true
server.restrictInternalApis: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jloleysens @pgayvallet suggests a CLI implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested to do something else in https://github.com/elastic/kibana/pull/161733/files#r1262308667 because the purpose of the linked PR was to enabled restricted API mode for tests, and enabling it globally wasn't the best way of doing so.

If your PR intends to enabled the restriction in production, then uncommenting the value in the serverless config file makes sense.

# Telemetry enabled by default and not disableable via UI
telemetry.optIn: true
telemetry.allowChangingOptInStatus: false
Expand Down