[Synthetics] Handle a case where settings were never saved #161834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
shahzad31
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Jul 18, 2023
…61834) Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 41a8a1d) # Conflicts: # x-pack/plugins/uptime/tsconfig.json
awahab07
added a commit
that referenced
this pull request
Jul 19, 2023
…1834) (#162185) # Backport This will backport the following commits from `main` to `8.9`: - [[Synthetics] Handle a case where settings were never saved (#161834)](#161834) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-18T16:09:11Z","message":"[Synthetics] Handle a case where settings were never saved (#161834)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"41a8a1db011c63107921c8446d33d94991cfb67b","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.10.0"],"number":161834,"url":"https://github.com/elastic/kibana/pull/161834","mergeCommit":{"message":"[Synthetics] Handle a case where settings were never saved (#161834)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"41a8a1db011c63107921c8446d33d94991cfb67b"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161834","number":161834,"mergeCommit":{"message":"[Synthetics] Handle a case where settings were never saved (#161834)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"41a8a1db011c63107921c8446d33d94991cfb67b"}}]}] BACKPORT--> --------- Co-authored-by: Shahzad <[email protected]> Co-authored-by: kibanamachine <[email protected]>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…61834) Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this is a follow up to #160063
Handle a case where settings were never saved !!
So let's say user never said settings, in that case the default values always included
synthetics-*pattern, so for this we still need to add that for existing alerts.