Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Stop click propagation on tooltip #161565

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[Infra UI] Stop click propagation on tooltip #161565

merged 1 commit into from
Jul 10, 2023

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Jul 10, 2023 •
edited by kibanamachine
Loading

fixes #161553

Summary

Fixes click event on the tooltip content

tooltip_fix.mov

How to test

  • Start a local Kibana instance
  • Navigate to Infrastructure > Hosts
  • Click on the ? icon in the table column headers and then click on the content. It must not sort the table

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos crespocarlos added Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ObsHosts Hosts feature within Observability v8.9.0 v8.10.0 labels Jul 10, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB +33.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 408 412 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 487 491 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crespocarlos crespocarlos marked this pull request as ready for review July 10, 2023 16:27
@crespocarlos crespocarlos requested a review from a team as a code owner July 10, 2023 16:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@crespocarlos crespocarlos merged commit 6c2170d into elastic:main Jul 10, 2023
@crespocarlos crespocarlos deleted the 161553-stop-click-event-propagation-on-tooltip branch July 10, 2023 17:32
@kibanamachine kibanamachine mentioned this pull request Jul 10, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 10, 2023
@crespocarlos
[Infra UI] Stop click propagation on tooltip (elastic#161565)
d79e480 
fixes [elastic#161553](elastic#161553)

## Summary

Fixes click event on the tooltip content

https://github.com/elastic/kibana/assets/2767137/13c8fde1-7dfe-4fb0-92f2-b3e45bd36972

### How to test

- Start a local Kibana instance
- Navigate to `Infrastructure` > `Hosts`
- Click on the `?` icon in the table column headers and then click on
the content. It must not sort the table

(cherry picked from commit 6c2170d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 10, 2023
@kibanamachine @crespocarlos
[8.9] [Infra UI] Stop click propagation on tooltip (#161565) (#161579)
ab0f158 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Infra UI] Stop click propagation on tooltip
(#161565)](#161565)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-10T17:32:11Z","message":"[Infra
UI] Stop click propagation on tooltip (#161565)\n\nfixes
[#161553](https://github.com/elastic/kibana/issues/161553)\r\n\r\n##
Summary\r\n\r\nFixes click event on the tooltip
content\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2767137/13c8fde1-7dfe-4fb0-92f2-b3e45bd36972\r\n\r\n\r\n###
How to test\r\n\r\n- Start a local Kibana instance\r\n- Navigate to
`Infrastructure` > `Hosts`\r\n- Click on the `?` icon in the table
column headers and then click on\r\nthe content. It must not sort the
table","sha":"6c2170d3856360f25371d30d14b0b0efaf48252f","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Metrics
UI","Team:Infra Monitoring
UI","release_note:skip","backport:prev-minor","Feature:ObsHosts","v8.9.0","v8.10.0"],"number":161565,"url":"https://github.com/elastic/kibana/pull/161565","mergeCommit":{"message":"[Infra
UI] Stop click propagation on tooltip (#161565)\n\nfixes
[#161553](https://github.com/elastic/kibana/issues/161553)\r\n\r\n##
Summary\r\n\r\nFixes click event on the tooltip
content\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2767137/13c8fde1-7dfe-4fb0-92f2-b3e45bd36972\r\n\r\n\r\n###
How to test\r\n\r\n- Start a local Kibana instance\r\n- Navigate to
`Infrastructure` > `Hosts`\r\n- Click on the `?` icon in the table
column headers and then click on\r\nthe content. It must not sort the
table","sha":"6c2170d3856360f25371d30d14b0b0efaf48252f"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161565","number":161565,"mergeCommit":{"message":"[Infra
UI] Stop click propagation on tooltip (#161565)\n\nfixes
[#161553](https://github.com/elastic/kibana/issues/161553)\r\n\r\n##
Summary\r\n\r\nFixes click event on the tooltip
content\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2767137/13c8fde1-7dfe-4fb0-92f2-b3e45bd36972\r\n\r\n\r\n###
How to test\r\n\r\n- Start a local Kibana instance\r\n- Navigate to
`Infrastructure` > `Hosts`\r\n- Click on the `?` icon in the table
column headers and then click on\r\nthe content. It must not sort the
table","sha":"6c2170d3856360f25371d30d14b0b0efaf48252f"}}]}] BACKPORT-->

Co-authored-by: Carlos Crespo <[email protected]>
@jennypavlova jennypavlova mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neptunian neptunian neptunian approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra UI] Table sorting is affected by clicking the info tooltip
6 participants
@crespocarlos @apmmachine @kibana-ci @elasticmachine @kibanamachine @neptunian