Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.9] [Migrations] Only pickup updated SO types when performing a compatible migration (#159962) #161010

Merged
merged 1 commit into from
Jun 30, 2023
Merged

[8.9] [Migrations] Only pickup updated SO types when performing a compatible migration (#159962) #161010

merged 1 commit into from
Jun 30, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

@gsoldevila
[Migrations] Only pickup updated SO types when performing a compatibl…
298cf24 
…e migration (elastic#159962)

## Summary

Tackles the first improvement described in
elastic#160038.

When "picking up" the updated mappings, we add a "query" in order to
select and update only the SO types that have been updated, compared to
the previous version.

We achieve this by comparing `migrationMappingPropertyHashes`; we
compare the hashes stored in the
`<soIndex>.mapping._meta.migrationMappingPropertyHashes` against the
ones calculated from the definitions from the `typeRegistry`.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 6f87e1d)
@kibanamachine kibanamachine enabled auto-merge (squash) June 30, 2023 14:46
@kibanamachine kibanamachine mentioned this pull request Jun 30, 2023
Merged
@kibanamachine kibanamachine merged commit 0fbb6ef into elastic:8.9 Jun 30, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-saved-objects-migration-server-internal 89 90 +1
Unknown metric groups

API count

id before after diff
@kbn/core-saved-objects-migration-server-internal 123 124 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 415 419 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 496 500 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gsoldevila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@gsoldevila gsoldevila

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @gsoldevila