-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NA): checking pr author through github.head_ref instead of pull_request event on auto backport approve ghaction #160807
Merged
mistic
merged 2 commits into
elastic:main
from
mistic:update-autobackport-action-logic-for-pr-author
Jun 28, 2023
Merged
fix(NA): checking pr author through github.head_ref instead of pull_request event on auto backport approve ghaction #160807
mistic
merged 2 commits into
elastic:main
from
mistic:update-autobackport-action-logic-for-pr-author
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest event on auto backport approve ghaction
mistic
added
chore
Team:Operations
Team label for Operations Team
release_note:skip
Skip the PR/issue when compiling release notes
backport:all-open
Backport to all branches that could still receive a release
labels
Jun 28, 2023
Pinging @elastic/kibana-operations (Team:Operations) |
Ikuni17
approved these changes
Jun 28, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 28, 2023
…equest event on auto backport approve ghaction (elastic#160807) The action is getting skipped on backports and I suspect we were not checking correctly for the pr author. I changed it a little to make sure we are getting the pr author through the head ref so we can validate is being created by kibanamachine. (cherry picked from commit c7b2d2b)
This was referenced Jun 28, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 28, 2023
…equest event on auto backport approve ghaction (elastic#160807) The action is getting skipped on backports and I suspect we were not checking correctly for the pr author. I changed it a little to make sure we are getting the pr author through the head ref so we can validate is being created by kibanamachine. (cherry picked from commit c7b2d2b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mistic
added a commit
that referenced
this pull request
Jun 28, 2023
…pull_request event on auto backport approve ghaction (#160807) (#160809) # Backport This will backport the following commits from `main` to `8.9`: - [fix(NA): checking pr author through github.head_ref instead of pull_request event on auto backport approve ghaction (#160807)](#160807) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-28T19:56:11Z","message":"fix(NA): checking pr author through github.head_ref instead of pull_request event on auto backport approve ghaction (#160807)\n\nThe action is getting skipped on backports and I suspect we were not\r\nchecking correctly for the pr author. I changed it a little to make sure\r\nwe are getting the pr author through the head ref so we can validate is\r\nbeing created by kibanamachine.","sha":"c7b2d2be8a558b906b3924ec947bd14cd3a963e6","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0"],"number":160807,"url":"https://github.com/elastic/kibana/pull/160807","mergeCommit":{"message":"fix(NA): checking pr author through github.head_ref instead of pull_request event on auto backport approve ghaction (#160807)\n\nThe action is getting skipped on backports and I suspect we were not\r\nchecking correctly for the pr author. I changed it a little to make sure\r\nwe are getting the pr author through the head ref so we can validate is\r\nbeing created by kibanamachine.","sha":"c7b2d2be8a558b906b3924ec947bd14cd3a963e6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160807","number":160807,"mergeCommit":{"message":"fix(NA): checking pr author through github.head_ref instead of pull_request event on auto backport approve ghaction (#160807)\n\nThe action is getting skipped on backports and I suspect we were not\r\nchecking correctly for the pr author. I changed it a little to make sure\r\nwe are getting the pr author through the head ref so we can validate is\r\nbeing created by kibanamachine.","sha":"c7b2d2be8a558b906b3924ec947bd14cd3a963e6"}}]}] BACKPORT--> Co-authored-by: Tiago Costa <[email protected]>
mistic
added a commit
that referenced
this pull request
Jun 28, 2023
… pull_request event on auto backport approve ghaction (#160807) (#160808) # Backport This will backport the following commits from `main` to `7.17`: - [fix(NA): checking pr author through github.head_ref instead of pull_request event on auto backport approve ghaction (#160807)](#160807) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-28T19:56:11Z","message":"fix(NA): checking pr author through github.head_ref instead of pull_request event on auto backport approve ghaction (#160807)\n\nThe action is getting skipped on backports and I suspect we were not\r\nchecking correctly for the pr author. I changed it a little to make sure\r\nwe are getting the pr author through the head ref so we can validate is\r\nbeing created by kibanamachine.","sha":"c7b2d2be8a558b906b3924ec947bd14cd3a963e6","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0"],"number":160807,"url":"https://github.com/elastic/kibana/pull/160807","mergeCommit":{"message":"fix(NA): checking pr author through github.head_ref instead of pull_request event on auto backport approve ghaction (#160807)\n\nThe action is getting skipped on backports and I suspect we were not\r\nchecking correctly for the pr author. I changed it a little to make sure\r\nwe are getting the pr author through the head ref so we can validate is\r\nbeing created by kibanamachine.","sha":"c7b2d2be8a558b906b3924ec947bd14cd3a963e6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160807","number":160807,"mergeCommit":{"message":"fix(NA): checking pr author through github.head_ref instead of pull_request event on auto backport approve ghaction (#160807)\n\nThe action is getting skipped on backports and I suspect we were not\r\nchecking correctly for the pr author. I changed it a little to make sure\r\nwe are getting the pr author through the head ref so we can validate is\r\nbeing created by kibanamachine.","sha":"c7b2d2be8a558b906b3924ec947bd14cd3a963e6"}}]}] BACKPORT--> Co-authored-by: Tiago Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:all-open
Backport to all branches that could still receive a release
chore
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.17.11
v8.9.0
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action is getting skipped on backports and I suspect we were not checking correctly for the pr author. I changed it a little to make sure we are getting the pr author through the head ref so we can validate is being created by kibanamachine.