Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v59 (main) #160700

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Update dependency @elastic/charts to v59 (main) #160700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b91adb2
Update dependency @elastic/charts to v59
renovate[bot] Jun 28, 2023
bdffa55
fix legend order in tests
markov00 Jun 28, 2023
f09c394
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Jun 28, 2023
7913a9b
fix(test): update legend sorted items
markov00 Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"@dnd-kit/utilities": "^2.0.0",
"@elastic/apm-rum": "^5.12.0",
"@elastic/apm-rum-react": "^1.4.2",
"@elastic/charts": "58.2.0",
"@elastic/charts": "59.0.0",
"@elastic/datemath": "5.0.3",
"@elastic/elasticsearch": "npm:@elastic/[email protected]",
"@elastic/ems-client": "8.4.0",
Expand Down
4 changes: 2 additions & 2 deletions test/functional/apps/discover/group1/_discover_histogram_breakdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.chooseBreakdownField('extension.raw');
await PageObjects.header.waitUntilLoadingHasFinished();
const list = await PageObjects.discover.getHistogramLegendList();
expect(list).to.eql(['Other', 'png', 'css', 'jpg']);
expect(list).to.eql(['jpg', 'css', 'png', 'Other']);
});

it('should add filter using histogram legend values', async () => {
Expand All @@ -55,7 +55,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.loadSavedSearch('with breakdown');
await PageObjects.header.waitUntilLoadingHasFinished();
const list = await PageObjects.discover.getHistogramLegendList();
expect(list).to.eql(['Other', 'png', 'css', 'jpg']);
expect(list).to.eql(['jpg', 'css', 'png', 'Other']);
});
});
}
34 changes: 17 additions & 17 deletions test/functional/apps/visualize/replaced_vislib_chart_types/_vertical_bar_chart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.visChart.waitForVisualizationRenderingStabilized();
await PageObjects.visEditor.clickGo(true);

const expectedEntries = ['503', '404', '200']; // sorting aligned with rendered geometries
const expectedEntries = ['200', '404', '503']; // sorting order aligned with the reading direction
const legendEntries = await PageObjects.visChart.getLegendEntriesXYCharts(xyChartSelector);
expect(legendEntries).to.eql(expectedEntries);
});
Expand All @@ -309,7 +309,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.visEditor.selectCustomSortMetric(3, 'Min', 'bytes');
await PageObjects.visEditor.clickGo(true);

const expectedEntries = ['503', '200', '404'];
const expectedEntries = ['404', '200', '503'];
const legendEntries = await PageObjects.visChart.getLegendEntriesXYCharts(xyChartSelector);
expect(legendEntries).to.eql(expectedEntries);
});
Expand Down Expand Up @@ -343,21 +343,21 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.visEditor.clickGo(true);

const expectedEntries = [
'404 - win xp',
'404 - win 8',
'404 - win 7',
'404 - osx',
'503 - win xp',
'503 - win 8',
'503 - win 7',
'503 - osx',
'503 - ios',
'404 - ios',
'200 - win 7',
'200 - osx',
'200 - ios',
'200 - win xp',
'200 - win 8',
'200 - win xp',
'200 - ios',
'200 - osx',
'200 - win 7',
'404 - ios',
'503 - ios',
'503 - osx',
'503 - win 7',
'503 - win 8',
'503 - win xp',
'404 - osx',
'404 - win 7',
'404 - win 8',
'404 - win xp',
];
const legendEntries = await PageObjects.visChart.getLegendEntriesXYCharts(xyChartSelector);
expect(legendEntries).to.eql(expectedEntries);
Expand All @@ -369,7 +369,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.visEditor.toggleDisabledAgg(3);
await PageObjects.visEditor.clickGo(true);

const expectedEntries = ['win 7', 'osx', 'ios', 'win xp', 'win 8'];
const expectedEntries = ['win 8', 'win xp', 'ios', 'osx', 'win 7'];
const legendEntries = await PageObjects.visChart.getLegendEntriesXYCharts(xyChartSelector);
expect(legendEntries).to.eql(expectedEntries);
});
Expand Down
32 changes: 16 additions & 16 deletions ...functional/apps/visualize/replaced_vislib_chart_types/_vertical_bar_chart_nontimeindex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.visEditor.clickGo(true);
await PageObjects.header.waitUntilLoadingHasFinished();

const expectedEntries = ['503', '404', '200']; // sorting aligned with rendered geometries
const expectedEntries = ['200', '404', '503']; // sorting order aligned with reading direction top-bottom

const legendEntries = await PageObjects.visChart.getLegendEntriesXYCharts(xyChartSelector);
expect(legendEntries).to.eql(expectedEntries);
Expand Down Expand Up @@ -212,21 +212,21 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.header.waitUntilLoadingHasFinished();

const expectedEntries = [
'404 - win xp',
'404 - win 8',
'404 - win 7',
'404 - osx',
'503 - win xp',
'503 - win 8',
'503 - win 7',
'503 - osx',
'503 - ios',
'404 - ios',
'200 - win 7',
'200 - osx',
'200 - ios',
'200 - win xp',
'200 - win 8',
'200 - win xp',
'200 - ios',
'200 - osx',
'200 - win 7',
'404 - ios',
'503 - ios',
'503 - osx',
'503 - win 7',
'503 - win 8',
'503 - win xp',
'404 - osx',
'404 - win 7',
'404 - win 8',
'404 - win xp',
];
const legendEntries = await PageObjects.visChart.getLegendEntriesXYCharts(xyChartSelector);
expect(legendEntries).to.eql(expectedEntries);
Expand All @@ -237,7 +237,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.visEditor.clickGo(true);
await PageObjects.header.waitUntilLoadingHasFinished();

const expectedEntries = ['win 7', 'osx', 'ios', 'win xp', 'win 8'];
const expectedEntries = ['win 8', 'win xp', 'ios', 'osx', 'win 7'];
const legendEntries = await PageObjects.visChart.getLegendEntriesXYCharts(xyChartSelector);
expect(legendEntries).to.eql(expectedEntries);
});
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/discover/visualize_field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
);

expect(await breakdownLabel.getVisibleText()).to.eql('Top 3 values of extension.raw');
expect(values).to.eql(['Other', 'png', 'css', 'jpg']);
expect(values).to.eql(['jpg', 'css', 'png', 'Other']);
});
});

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,10 +1469,10 @@
dependencies:
object-hash "^1.3.0"

"@elastic/charts@58.2.0":
version "58.2.0"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-58.2.0.tgz#bd2010a4081b565f539abc75938431c7590213cc"
integrity sha512-ZhW+3SHz6txVdrncSt3njTunmUwdL4JF5lSXy5NG8qrx0r4SKi3yLbLc83xAsv7T1hxbTgsfS4GgGMhWoBBiyg==
"@elastic/charts@59.0.0":
version "59.0.0"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-59.0.0.tgz#c81a82c389011f52ac79e7c59b0551439a0e90b2"
integrity sha512-itEam7dpyHxMNl8eNnZbQa/7M6D741/qsZWjDnXXlirvRsMzpRwhuB0WGxGNXxCuuW/GqWXNlhsqXgKqERS4yw==
dependencies:
"@popperjs/core" "^2.4.0"
bezier-easing "^2.1.0"
Expand Down