Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Move maintenance window callout to @kbn/alerts-ui-shared package #160678

Merged
merged 20 commits into from
Jul 6, 2023

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jun 27, 2023

Summary

Moves the Security Solution's MaintenanceWindowCallout into a shared KBN package to make it more accessible by other plugins.

Checklist

@Zacqary Zacqary added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0 labels Jun 27, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@Zacqary Zacqary marked this pull request as ready for review June 29, 2023 16:21
@Zacqary Zacqary requested review from a team as code owners June 29, 2023 16:21
@Zacqary Zacqary requested a review from dplumlee June 29, 2023 16:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@banderror banderror requested a review from nikitaindik June 30, 2023 08:31
@nikitaindik
Copy link
Contributor

Thanks! Changes LGTM.

@Zacqary Zacqary enabled auto-merge (squash) June 30, 2023 15:41
@banderror banderror removed the request for review from dplumlee July 4, 2023 09:02
@Zacqary
Copy link
Contributor Author

Zacqary commented Jul 6, 2023

@elasticmachine merge upstream

@Zacqary Zacqary merged commit 0dc7312 into elastic:main Jul 6, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Add, copy comments in different exceptions type and validate sharing them between users Endpoint exceptions Add comment on a new exception, and add another comment has unicode character from a different user

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 425 429 +4
securitySolution 4242 4244 +2
triggersActionsUi 566 570 +4
total +10

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/alerts-ui-shared 4 7 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.0MB 1.0MB +2.2KB
securitySolution 11.0MB 11.0MB +440.0B
triggersActionsUi 1.4MB 1.4MB +1.5KB
total +4.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/alerts-ui-shared 0 1 +1
Unknown metric groups

API count

id before after diff
@kbn/alerts-ui-shared 5 8 +3

ESLint disabled line counts

id before after diff
@kbn/alerts-ui-shared 0 2 +2
enterpriseSearch 14 16 +2
securitySolution 410 412 +2
total +6

Total ESLint disabled count

id before after diff
@kbn/alerts-ui-shared 0 2 +2
enterpriseSearch 15 17 +2
securitySolution 489 491 +2
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants