Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Add panel redesign #160656

Closed
wants to merge 4 commits into from

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Jun 27, 2023

Summary

Closes #144418.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 27, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #6 / dashboard app - group 1 create and add embeddables ensure toolbar popover closes on add
  • [job] [logs] FTR Configs #6 / dashboard app - group 1 create and add embeddables ensure toolbar popover closes on add
  • [job] [logs] FTR Configs #24 / dashboard app - group 1 empty dashboard should add new visualization from dashboard
  • [job] [logs] FTR Configs #24 / dashboard app - group 1 empty dashboard should add new visualization from dashboard
  • [job] [logs] test/functional/apps/dashboard/group2/config.ts / dashboard app - group 2 dashboard view edit mode shows lose changes warning and loses changes on confirmation when a new vis is added
  • [job] [logs] test/functional/apps/dashboard/group2/config.ts / dashboard app - group 2 dashboard view edit mode shows lose changes warning and loses changes on confirmation when a new vis is added
  • [job] [logs] FTR Configs #42 / dashboard app - group 3 dashboard panel copy to "before all" hook for "does not show the new dashboard option when on a new dashboard"
  • [job] [logs] FTR Configs #42 / dashboard app - group 3 dashboard panel copy to "before all" hook for "does not show the new dashboard option when on a new dashboard"
  • [job] [logs] FTR Configs #31 / dashboard app - group 4 dashboard save Does not show dashboard save modal when on quick save
  • [job] [logs] FTR Configs #31 / dashboard app - group 4 dashboard save Does not show dashboard save modal when on quick save
  • [job] [logs] FTR Configs #62 / dashboard dashboard maps by value adding a map by value can add a map by value
  • [job] [logs] FTR Configs #62 / dashboard dashboard maps by value adding a map by value can add a map by value
  • [job] [logs] test/functional/apps/dashboard_elements/config.ts / dashboard elements dashboard elements Controls Options list control Interactions between options list and dashboard Applies query settings to controls dashboard filters Applies dashboard filters to options list control
  • [job] [logs] test/functional/apps/dashboard_elements/config.ts / dashboard elements dashboard elements Controls Options list control Interactions between options list and dashboard Applies query settings to controls dashboard filters Applies dashboard filters to options list control
  • [job] [logs] FTR Configs #21 / dashboard feature controls dashboard time to visualize security visualize by value works without library save permissions can add a markdown panel by value
  • [job] [logs] FTR Configs #21 / dashboard feature controls dashboard time to visualize security visualize by value works without library save permissions can add a markdown panel by value
  • [job] [logs] FTR Configs #55 / dashboard save Does not show dashboard save modal when on quick save
  • [job] [logs] FTR Configs #55 / dashboard save Does not show dashboard save modal when on quick save
  • [job] [logs] FTR Configs #26 / lens app - TSVB Open in Lens Convert to Lens action on dashboard should show notification in context menu if visualization can be converted
  • [job] [logs] FTR Configs #26 / lens app - TSVB Open in Lens Convert to Lens action on dashboard should show notification in context menu if visualization can be converted
  • [job] [logs] FTR Configs #2 / lens app - TSVB Open in Lens Dashboard to TSVB to Lens should convert a by reference TSVB viz to a Lens viz
  • [job] [logs] FTR Configs #2 / lens app - TSVB Open in Lens Dashboard to TSVB to Lens should convert a by reference TSVB viz to a Lens viz
  • [job] [logs] FTR Configs #44 / machine learning - anomaly detection anomaly charts in dashboard with multi metric job can open job selection flyout
  • [job] [logs] FTR Configs #44 / machine learning - anomaly detection anomaly charts in dashboard with multi metric job can open job selection flyout
  • [job] [logs] FTR Configs #26 / machine learning embeddables anomaly charts Accessibility with multi metric job can open job selection flyout
  • [job] [logs] FTR Configs #26 / machine learning embeddables anomaly charts Accessibility with multi metric job can open job selection flyout
  • [job] [logs] FTR Configs #30 / maps app embeddable save and return work flow new map "before each" hook for "should return to dashboard and add new panel"
  • [job] [logs] FTR Configs #30 / maps app embeddable save and return work flow new map "before each" hook for "should return to dashboard and add new panel"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 380 381 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 994.1KB 994.1KB +60.0B
dashboard 360.0KB 361.3KB +1.3KB
total +1.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1
Copy link
Contributor Author

cqliu1 commented Jun 13, 2024

Closing in favor of #183764.

@cqliu1 cqliu1 closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Redesign Add Panel Experience
3 participants