Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Revert skip for flaky Tests #160391

Merged

Conversation

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 492 496 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@achyutjhunjhunwala achyutjhunjhunwala marked this pull request as ready for review June 28, 2023 08:02
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner June 28, 2023 08:02
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇
For the functional tests maybe we need to create a ticket if there is no one already. I think it'd help with visibility of the tech debt rather than having it in the dev documentation.

TODO: We could try moving this tests to the new e2e tests located at x-pack/plugins/apm/ftr_e2e.

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jun 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@achyutjhunjhunwala achyutjhunjhunwala changed the title [APM] Revert skip for flaky Tests [WIP] [APM] Revert skip for flaky Tests Jun 28, 2023
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Jun 28, 2023
@achyutjhunjhunwala achyutjhunjhunwala added the release_note:skip Skip the PR/issue when compiling release notes label Jun 28, 2023
@achyutjhunjhunwala
Copy link
Contributor Author

LGTM 🥇 For the functional tests maybe we need to create a ticket if there is no one already. I think it'd help with visibility of the tech debt rather than having it in the dev documentation.

TODO: We could try moving this tests to the new e2e tests located at x-pack/plugins/apm/ftr_e2e.

@yngrdyn #160701

@achyutjhunjhunwala achyutjhunjhunwala merged commit 384cf78 into elastic:main Jun 28, 2023
@achyutjhunjhunwala achyutjhunjhunwala deleted the revert_flaky_tests_skip branch June 28, 2023 08:29
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jun 28, 2023
@@ -196,7 +192,6 @@ export class TimePickerPageObject extends FtrService {
await this.testSubjects.click('querySubmitButton');
}

await this.waitPanelIsGone(panel);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achyutjhunjhunwala did you intentionally remove these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as this was adding no value but more flakiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants