-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Revert skip for flaky Tests #160391
[APM] Revert skip for flaky Tests #160391
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
x-pack/test/apm_api_integration/tests/service_overview/instance_details.spec.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
For the functional tests maybe we need to create a ticket if there is no one already. I think it'd help with visibility of the tech debt rather than having it in the dev documentation.
TODO: We could try moving this tests to the new e2e tests located at x-pack/plugins/apm/ftr_e2e.
Pinging @elastic/apm-ui (Team:APM) |
|
@@ -196,7 +192,6 @@ export class TimePickerPageObject extends FtrService { | |||
await this.testSubjects.click('querySubmitButton'); | |||
} | |||
|
|||
await this.waitPanelIsGone(panel); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@achyutjhunjhunwala did you intentionally remove these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as this was adding no value but more flakiness.
Summary
Closes
Flakiness Testing
Changes in the PR were tested with the flaky test runner, running 50 times for all 5 configs for APM
apm_api_integration
folder andfunctional/apps/apm
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2499