[Security Solution] Rule is created when the conditional logic "If alert matches a query" is left blank #159690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ert matches a query" is left blank elastic#156706
e40pud
added
release_note:fix
Team:Detections and Resp
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
e40pud
commented
Jun 14, 2023
| return setFieldErrors(null); | ||
| } | ||
| if (isSubmitted && !isSubmitting && isValid === false && field.errors.length) { | ||
| if (isValid === false) { |
There was a problem hiding this comment.
After recent changes we do not call form.submit() on rule creation, thus we cannot rely on isSubmitting and isSubmitted anymore here. Those two parameters will not be changed at all and we will not show error callout. Updated to only check whether isValid field of the form has been updated, which happens when user clicks create button.
banderror
approved these changes
Jun 15, 2023
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
Zacqary
approved these changes
Jun 30, 2023
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @e40pud |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 11, 2023
…ert matches a query" is left blank (elastic#159690) ## Summary Original ticket: elastic#156706 These changes prevent user from creating/updating the rule when alert filter is selected and query left blank on the rule's action page. We gonna show an error saying "A custom query is required." in this case. <img width="1739" alt="Screenshot 2023-06-14 at 14 36 35" src="https://github.com/elastic/kibana/assets/2700761/0456f211-603c-44d9-9271-9cfdf59f12b6"> Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 9b6ad72)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 11, 2023
…"If alert matches a query" is left blank (#159690) (#161665) # Backport This will backport the following commits from `main` to `8.9`: - [[Security Solution] Rule is created when the conditional logic "If alert matches a query" is left blank (#159690)](#159690) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-11T14:27:24Z","message":"[Security Solution] Rule is created when the conditional logic \"If alert matches a query\" is left blank (#159690)\n\n## Summary\r\n\r\nOriginal ticket: https://github.com/elastic/kibana/issues/156706\r\n\r\nThese changes prevent user from creating/updating the rule when alert\r\nfilter is selected and query left blank on the rule's action page. We\r\ngonna show an error saying \"A custom query is required.\" in this case.\r\n\r\n<img width=\"1739\" alt=\"Screenshot 2023-06-14 at 14 36 35\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/0456f211-603c-44d9-9271-9cfdf59f12b6\">\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"9b6ad7280de61c0ed1471eda54b98a64d485b637","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","ci:cloud-deploy","Team:Detection Engine","v8.10.0","v8.9.1"],"number":159690,"url":"https://github.com/elastic/kibana/pull/159690","mergeCommit":{"message":"[Security Solution] Rule is created when the conditional logic \"If alert matches a query\" is left blank (#159690)\n\n## Summary\r\n\r\nOriginal ticket: https://github.com/elastic/kibana/issues/156706\r\n\r\nThese changes prevent user from creating/updating the rule when alert\r\nfilter is selected and query left blank on the rule's action page. We\r\ngonna show an error saying \"A custom query is required.\" in this case.\r\n\r\n<img width=\"1739\" alt=\"Screenshot 2023-06-14 at 14 36 35\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/0456f211-603c-44d9-9271-9cfdf59f12b6\">\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"9b6ad7280de61c0ed1471eda54b98a64d485b637"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159690","number":159690,"mergeCommit":{"message":"[Security Solution] Rule is created when the conditional logic \"If alert matches a query\" is left blank (#159690)\n\n## Summary\r\n\r\nOriginal ticket: https://github.com/elastic/kibana/issues/156706\r\n\r\nThese changes prevent user from creating/updating the rule when alert\r\nfilter is selected and query left blank on the rule's action page. We\r\ngonna show an error saying \"A custom query is required.\" in this case.\r\n\r\n<img width=\"1739\" alt=\"Screenshot 2023-06-14 at 14 36 35\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/0456f211-603c-44d9-9271-9cfdf59f12b6\">\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"9b6ad7280de61c0ed1471eda54b98a64d485b637"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Original ticket: #156706
These changes prevent user from creating/updating the rule when alert filter is selected and query left blank on the rule's action page. We gonna show an error saying "A custom query is required." in this case.