-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usage of public SO client with Fleet get Bulk Assets api #159653
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
@elasticmachine merge upstream |
Pinging @elastic/fleet (Team:Fleet) |
x-pack/plugins/monitoring/public/application/pages/elasticsearch/ingest_pipeline_modal.tsx
Outdated
Show resolved
Hide resolved
const { assetIds } = request.body; | ||
const savedObjectsClient = (await context.fleet).internalSoClient; | ||
const assets = await getBulkAssets(savedObjectsClient, assetIds as AssetSOObject[]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored this as I was trying to export it with PackageService
from /server/plugin
, so I decided to keep this change even if it's not strictly related to this PR
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @criamico |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #158598
Summary
Removes usage of deprecated SO client to fetch dashboard assets; Replaced with a call to the new Fleet endpoint
epm/bulk_assets
(openapi)Testing
I'm not very familiar with stack monitoring, so I tried to reproduce what's described in the PR that originally introduced this dashboard; I couldn't trigger the modal but I can see the endpoint in the network requests:
It should be enough to test this change since is very small.