fix(NA): build external plugins with correct bazel artifacts output mode #159630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
Team:Operations
…-ref HEAD~1..HEAD --fix'
…put-mode' of github.com:mistic/kibana into build-external-plugins-with-correct-bazel-artifacts-output-mode
…-ref HEAD~1..HEAD --fix'
mistic
added
auto-backport
|
Pinging @elastic/kibana-operations (Team:Operations) |
…tifacts-output-mode
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Jun 14, 2023
kibanamachine
pushed a commit
that referenced
this pull request
Jun 14, 2023
…ode (#159630) Closes #159328 , #154325, #157440 This PR fixes a problem in the plugin helpers tasks used to build external plugins. After changes to transpile packages differently in the past months a bug was introduced and external plugins were being built with the wrong shared ui deps output mode causing development form imports to be bundled and causing problems at page load time. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 7e067ec)
kibanamachine
pushed a commit
that referenced
this pull request
Jun 14, 2023
…ode (#159630) Closes #159328 , #154325, #157440 This PR fixes a problem in the plugin helpers tasks used to build external plugins. After changes to transpile packages differently in the past months a bug was introduced and external plugins were being built with the wrong shared ui deps output mode causing development form imports to be bundled and causing problems at page load time. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 7e067ec)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mistic
added a commit
that referenced
this pull request
Jun 14, 2023
…tput mode (#159630) (#159760) # Backport This will backport the following commits from `main` to `8.7`: - [fix(NA): build external plugins with correct bazel artifacts output mode (#159630)](#159630) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-14T23:43:05Z","message":"fix(NA): build external plugins with correct bazel artifacts output mode (#159630)\n\nCloses #159328 ,\r\nhttps://github.com//issues/154325,\r\nhttps://github.com//issues/157440\r\n\r\nThis PR fixes a problem in the plugin helpers tasks used to build\r\nexternal plugins. After changes to transpile packages differently in the\r\npast months a bug was introduced and external plugins were being built\r\nwith the wrong shared ui deps output mode causing development form\r\nimports to be bundled and causing problems at page load time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","auto-backport","v8.7.2","v8.9.0","v8.8.2"],"number":159630,"url":"https://github.com/elastic/kibana/pull/159630","mergeCommit":{"message":"fix(NA): build external plugins with correct bazel artifacts output mode (#159630)\n\nCloses #159328 ,\r\nhttps://github.com//issues/154325,\r\nhttps://github.com//issues/157440\r\n\r\nThis PR fixes a problem in the plugin helpers tasks used to build\r\nexternal plugins. After changes to transpile packages differently in the\r\npast months a bug was introduced and external plugins were being built\r\nwith the wrong shared ui deps output mode causing development form\r\nimports to be bundled and causing problems at page load time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7"}},"sourceBranch":"main","suggestedTargetBranches":["8.7","8.8"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159630","number":159630,"mergeCommit":{"message":"fix(NA): build external plugins with correct bazel artifacts output mode (#159630)\n\nCloses #159328 ,\r\nhttps://github.com//issues/154325,\r\nhttps://github.com//issues/157440\r\n\r\nThis PR fixes a problem in the plugin helpers tasks used to build\r\nexternal plugins. After changes to transpile packages differently in the\r\npast months a bug was introduced and external plugins were being built\r\nwith the wrong shared ui deps output mode causing development form\r\nimports to be bundled and causing problems at page load time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tiago Costa <[email protected]>
mistic
added a commit
that referenced
this pull request
Jun 15, 2023
…tput mode (#159630) (#159761) # Backport This will backport the following commits from `main` to `8.8`: - [fix(NA): build external plugins with correct bazel artifacts output mode (#159630)](#159630) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-14T23:43:05Z","message":"fix(NA): build external plugins with correct bazel artifacts output mode (#159630)\n\nCloses #159328 ,\r\nhttps://github.com//issues/154325,\r\nhttps://github.com//issues/157440\r\n\r\nThis PR fixes a problem in the plugin helpers tasks used to build\r\nexternal plugins. After changes to transpile packages differently in the\r\npast months a bug was introduced and external plugins were being built\r\nwith the wrong shared ui deps output mode causing development form\r\nimports to be bundled and causing problems at page load time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","auto-backport","v8.7.2","v8.9.0","v8.8.2"],"number":159630,"url":"https://github.com/elastic/kibana/pull/159630","mergeCommit":{"message":"fix(NA): build external plugins with correct bazel artifacts output mode (#159630)\n\nCloses #159328 ,\r\nhttps://github.com//issues/154325,\r\nhttps://github.com//issues/157440\r\n\r\nThis PR fixes a problem in the plugin helpers tasks used to build\r\nexternal plugins. After changes to transpile packages differently in the\r\npast months a bug was introduced and external plugins were being built\r\nwith the wrong shared ui deps output mode causing development form\r\nimports to be bundled and causing problems at page load time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7"}},"sourceBranch":"main","suggestedTargetBranches":["8.7","8.8"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159630","number":159630,"mergeCommit":{"message":"fix(NA): build external plugins with correct bazel artifacts output mode (#159630)\n\nCloses #159328 ,\r\nhttps://github.com//issues/154325,\r\nhttps://github.com//issues/157440\r\n\r\nThis PR fixes a problem in the plugin helpers tasks used to build\r\nexternal plugins. After changes to transpile packages differently in the\r\npast months a bug was introduced and external plugins were being built\r\nwith the wrong shared ui deps output mode causing development form\r\nimports to be bundled and causing problems at page load time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tiago Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159328 , #154325, #157440
This PR fixes a problem in the plugin helpers tasks used to build external plugins. After changes to transpile packages differently in the past months a bug was introduced and external plugins were being built with the wrong shared ui deps output mode causing development form imports to be bundled and causing problems at page load time.