Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs onboarding] Added give feedback button #159455

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Jun 12, 2023

Relates to #158843.

This PR adds Give feedback button on top of observability onboarding pages.

image

@yngrdyn yngrdyn requested a review from a team as a code owner June 12, 2023 12:13
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn changed the title Added give feedback button [Logs onboarding] Added give feedback button Jun 12, 2023
@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Jun 12, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 36 37 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 44.6KB 45.0KB +449.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 491 495 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

const OBSERVABILITY_ONBOARDING_FEEDBACK_LINK =
'https://ela.st/logs-onboarding-feedback';

export function ObservabilityOnboardingHeaderActionMenu() {
Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) why is it called a menu, when it's only one action ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right but it gives space to other actions to come into play there

Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yngrdyn yngrdyn merged commit 5fd356a into elastic:main Jun 12, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels Jun 12, 2023
@kpatticha
Copy link
Contributor

kpatticha commented Jun 12, 2023

fyi, just noticed that in serverless the button appears on the left
image

it seems it's due to the PR #158523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants