-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs onboarding] Added give feedback button #159455
[Logs onboarding] Added give feedback button #159455
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…o-the-onboarding-wizard
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌟
const OBSERVABILITY_ONBOARDING_FEEDBACK_LINK = | ||
'https://ela.st/logs-onboarding-feedback'; | ||
|
||
export function ObservabilityOnboardingHeaderActionMenu() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) why is it called a menu, when it's only one action ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right but it gives space to other actions to come into play there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
fyi, just noticed that in serverless the button appears on the left it seems it's due to the PR #158523 |
Relates to #158843.
This PR adds
Give feedback
button on top of observability onboarding pages.