-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
legacy agg vis tag cloud convert to lens #159348
Conversation
…-ref HEAD~1..HEAD --fix'
@elasticmachine merge upstream |
c25f484
to
95c5071
Compare
…-ref HEAD~1..HEAD --fix'
071d359
to
8a75918
Compare
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great, the only thing that is missing is to convert the tagcloud with significant terms to a terms breakdown with significance. Are we doing this in this PR?
@elasticmachine merge upstream |
No, I was going to add significance terms convert to lens support in a separate PR. Its in a different location in the code base and effects more then just tag cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! I tested it locally in Chrome and the navigation from legacy tagcloud to lens works as expected.
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Part of #154307
Add convert to lens logic for tag cloud visualization