-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text based] Enables save Lens chart to dashboard from Discover #159190
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@@ -271,6 +273,27 @@ export function Chart({ | |||
/> | |||
</EuiFlexItem> | |||
)} | |||
{isPlainRecord && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be better to create a variable like canSaveVisualization
and use it here and maybe on line 380.
Also, should we check user permissions too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we can follow the by value permissions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature! LGTM 👍
Summary
Adds a save to dashboard functionality in the Lens charts created in Discover by text based languages.
We allow only saving by value panels and not by reference because we are going to remove this functionality in the next minor (create Lens text based languages SOs).
Checklist