Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text based] Enables save Lens chart to dashboard from Discover #159190

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jun 7, 2023

Summary

Adds a save to dashboard functionality in the Lens charts created in Discover by text based languages.

image image

We allow only saving by value panels and not by reference because we are going to remove this functionality in the next minor (create Lens text based languages SOs).

Checklist

@stratoula stratoula added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.9.0 labels Jun 7, 2023
@stratoula stratoula marked this pull request as ready for review June 7, 2023 13:13
@stratoula stratoula requested a review from a team as a code owner June 7, 2023 13:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@@ -271,6 +273,27 @@ export function Chart({
/>
</EuiFlexItem>
)}
{isPlainRecord && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be better to create a variable like canSaveVisualization and use it here and maybe on line 380.

Also, should we check user permissions too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure we can follow the by value permissions here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #14 / machine learning - short tests model management trained models for ML power user displays a model with an ingest pipeline and model can be deleted with associated ingest pipelines

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
unifiedHistogram 23 24 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedHistogram 43.4KB 44.2KB +788.0B
Unknown metric groups

API count

id before after diff
unifiedHistogram 52 53 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 414 418 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 498 502 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! LGTM 👍

@stratoula stratoula merged commit 5c7753f into elastic:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants