[RAM] Fix flaky expiring snooze test #159138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
mikecote
reviewed
Jun 6, 2023
| }, | ||
| ]); | ||
| await retry.try(async () => { | ||
| expect(updatedAlert.snooze_schedule).to.eql([ |
There was a problem hiding this comment.
You will have to fetch the rule in this function instead so you can have updatedAlert eventually equal to what's expected.
const { body: updatedAlert } = await supertestWithoutAuth
.get(`${getUrlPrefix(Spaces.space1.id)}/internal/alerting/rule/${createdRule.id}`)
.set('kbn-xsrf', 'foo')
.expect(200);
There was a problem hiding this comment.
RIGHT WHOOPS thanks for that lmao
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
|
expected head sha didn’t match current head ref. |
|
AND WHOSE FAULT IS THAT @kibanamachine? NOT MINE |
|
I have no idea what's happening so I'm gonna reopen this PR |
auto-merge was automatically disabled
June 7, 2023 16:20
Pull request was closed
Zacqary
added a commit
that referenced
this pull request
Jun 8, 2023
## Summary Closes #159076 Wraps a flaky bit of test in retry.try Second attempt to merge #159138 after that one inexplicably got its git all in a twist or something --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #159076
Wraps a flaky bit of test in
retry.try