Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event annotations] Lens design improvements #159057

Merged
merged 14 commits into from
Jul 3, 2023
Merged

[Event annotations] Lens design improvements #159057

merged 14 commits into from
Jul 3, 2023

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Jun 5, 2023 •
edited
Loading

Summary

Resolve #158779

  • duplicate title checking
Screenshot 2023-06-30 at 2 46 23 PM
  • update empty dimension button text
Screenshot 2023-06-30 at 2 47 06 PM
  • update delete-layer modal text
Screenshot 2023-06-30 at 2 47 48 PM
  • vertically align load-annotation-group empty prompt
Screenshot 2023-06-30 at 2 50 12 PM
  • explanatory text when title is missing
Screenshot 2023-06-30 at 2 51 10 PM
  • remove ugly padding on success toast
Screenshot 2023-06-30 at 3 31 01 PM
  • other minor punctuation and positioning changes

Checklist

Delete any items that are not applicable to this PR.

@drewdaemon drewdaemon marked this pull request as ready for review June 30, 2023 21:31
@drewdaemon drewdaemon requested review from a team as code owners June 30, 2023 21:31
@drewdaemon drewdaemon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@drewdaemon drewdaemon added the release_note:skip Skip the PR/issue when compiling release notes label Jun 30, 2023
stratoula
stratoula approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, LGTM!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
eventAnnotation 234 236 +2
lens 527 529 +2
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
eventAnnotation 120.7KB 120.8KB +109.0B
lens 1.3MB 1.3MB +532.0B
total +641.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
eventAnnotation 27.6KB 27.8KB +124.0B
savedObjects 22.1KB 22.3KB +208.0B
total +332.0B
Unknown metric groups

API count

id before after diff
eventAnnotation 234 236 +2
lens 622 625 +3
total +5

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 492 496 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 1d82d2c into elastic:main Jul 3, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 3, 2023
@drewdaemon drewdaemon mentioned this pull request Jul 3, 2023
Merged
12 tasks
@drewdaemon drewdaemon added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Jul 3, 2023
@drewdaemon drewdaemon mentioned this pull request Jul 3, 2023
Merged
@drewdaemon
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

drewdaemon added a commit to drewdaemon/kibana that referenced this pull request Jul 3, 2023
@drewdaemon
[Event annotations] Lens design improvements (elastic#159057)
e2ae3e0 
(cherry picked from commit 1d82d2c)
drewdaemon added a commit that referenced this pull request Jul 3, 2023
@drewdaemon
[8.9] [Event annotations] Lens design improvements (#159057) (#161116)
8739470 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Event annotations] Lens design improvements
(#159057)](#159057)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Drew
Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-03T14:16:47Z","message":"[Event
annotations] Lens design improvements
(#159057)","sha":"1d82d2cb612483e96793d3b53669e19438bce28f","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.9.0","v8.10.0"],"number":159057,"url":"https://github.com/elastic/kibana/pull/159057","mergeCommit":{"message":"[Event
annotations] Lens design improvements
(#159057)","sha":"1d82d2cb612483e96793d3b53669e19438bce28f"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159057","number":159057,"mergeCommit":{"message":"[Event
annotations] Lens design improvements
(#159057)","sha":"1d82d2cb612483e96793d3b53669e19438bce28f"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] annotations final design feedback
6 participants
@drewdaemon @elasticmachine @kibana-ci @pgayvallet @stratoula @kibanamachine