Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Serverless] AppFeatures improvements #158935

Merged

Conversation

semd
Copy link
Contributor

@semd semd commented Jun 2, 2023

Summary

issue: #158810
follow-up of: #158179

Improves the Security AppFeatures architecture:

  • SubFeatures now preserve always the same order in the Security Kibana config, despite the order of processing of enabled appFeatures.

Security_sub_features

  • Change the productTypes config format
  • Update getProductAppFeatures to:
    • process the new productTypes format.
    • include essentials tiers PLIs inside complete tiers automatically.
  • AppFeatures module now receives an array of PLIs instead of an object
  • AppFeatures config now uses only SubFeature IDS instead of subActions config objects directly
  • Upselling components updated and useProductTypeByPLI implemented to display the Product Type required

@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.0 labels Jun 2, 2023
@semd semd self-assigned this Jun 2, 2023
@semd semd marked this pull request as ready for review June 2, 2023 15:00
@semd semd requested a review from a team as a code owner June 2, 2023 15:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@semd semd requested a review from a team as a code owner June 2, 2023 16:03
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Entity Analytics Dashboard With anomalies data renders table with pagination
  • [job] [logs] Defend Workflows Cypress Tests #1 / Isolate command from Manage "before all" hook for "should allow filtering endpoint by Isolated status"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
serverlessSecurity 97 163 +66

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
securitySolution 109 110 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
serverlessSecurity 9.9KB 10.7KB +748.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 51.0KB 51.0KB +87.0B
serverlessSecurity 35.2KB 48.2KB +13.1KB
total +13.2KB
Unknown metric groups

API count

id before after diff
securitySolution 153 154 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 414 418 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 498 502 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YulNaumenko YulNaumenko merged commit 0fe67b2 into elastic:main Jun 2, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 2, 2023
ashokaditya added a commit to ashokaditya/kibana that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants