Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] [Concept] Updating all callers of Code Editor to provide 'theme' service #158837

Conversation

kc13greiner
Copy link
Contributor

Summary

Attempting to provide theme service in each context/pass theme service down to all CodeEditor/CodeEditorField usages.

Current progress: ~ 20%

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 1, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / on component mount form submission should render an error message if error mapping pipeline
  • [job] [logs] Jest Tests #3 / Discover grid cell rendering renders a functional close button when CodeEditor is rendered
  • [job] [logs] Jest Tests #3 / FieldEditor should render create new scripted field correctly
  • [job] [logs] Jest Tests #3 / FieldEditor should render edit scripted field correctly
  • [job] [logs] Jest Tests #3 / FieldEditor should show conflict field warning
  • [job] [logs] Jest Tests #3 / FieldEditor should show deprecated lang warning
  • [job] [logs] Jest Tests #3 / FieldEditor should show multiple type field warning with a table containing indices
  • [job] [logs] Jest Tests #14 / Inspect component renders correctly
  • [job] [logs] FTR Configs #4 / Kibana roles page Accessibility a11y test for show/hide privilege toggle button
  • [job] [logs] FTR Configs #4 / Kibana roles page Accessibility a11y test for show/hide privilege toggle button
  • [job] [logs] Jest Tests #14 / SavedObjectEdition should render normally
  • [job] [logs] FTR Configs #40 / security app dls "after all" hook: logout for "user East should only see EAST doc"
  • [job] [logs] FTR Configs #40 / security app dls "after all" hook: logout for "user East should only see EAST doc"
  • [job] [logs] FTR Configs #40 / security app dls should add new role myroleEast
  • [job] [logs] FTR Configs #40 / security app dls should add new role myroleEast
  • [job] [logs] Jest Tests #3 / Source Viewer component renders json code editor

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
advancedSettings 54 56 +2
ingestPipelines 339 341 +2
inspector 40 42 +2
savedObjectsManagement 86 88 +2
visDefaultEditor 120 122 +2
visTypeTimelion 45 47 +2
total +12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 50.7KB 52.0KB +1.3KB
canvas 993.9KB 994.1KB +216.0B
data 52.8KB 52.9KB +163.0B
dataViewManagement 118.6KB 118.7KB +107.0B
discover 421.1KB 421.8KB +716.0B
ingestPipelines 453.4KB 454.1KB +686.0B
inspector 16.0KB 16.6KB +618.0B
savedObjectsManagement 87.6KB 88.3KB +680.0B
security 566.5KB 567.1KB +593.0B
serverlessSearch 45.5KB 45.9KB +422.0B
visDefaultEditor 141.0KB 141.6KB +595.0B
visTypeTimelion 38.8KB 39.4KB +631.0B
visTypeTimeseries 507.6KB 507.7KB +123.0B
total +6.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 10.2KB 10.3KB +49.0B
ingestPipelines 13.8KB 13.8KB +48.0B
inspector 21.7KB 21.8KB +97.0B
kibanaReact 51.9KB 51.8KB -141.0B
savedObjectsManagement 19.3KB 19.3KB +48.0B
serverlessSearch 26.1KB 26.1KB +48.0B
visDefaultEditor 21.2KB 21.4KB +174.0B
visTypeTimelion 10.6KB 10.7KB +97.0B
total +420.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kc13greiner kc13greiner deleted the bugfix/update_code_editor_theme_callers branch January 26, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants