Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Clarify support for data views in stack rules #158431

Merged
merged 2 commits into from
May 25, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented May 25, 2023

Summary

This PR updates the documentation for the index threshold and Elasticsearch query rules, since there were incorrect details about support for data views. It also updates the layout of the content to more closely match the UI and adds frontmatter for content migration.

@lcawl lcawl added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.9.0 labels May 25, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl marked this pull request as ready for review May 25, 2023 14:53
@lcawl lcawl requested a review from a team as a code owner May 25, 2023 14:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl merged commit 4981f37 into elastic:main May 25, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 25, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 25, 2023
…158463)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[DOCS] Clarify support for data views in stack rules
(#158431)](#158431)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-25T14:53:57Z","message":"[DOCS]
Clarify support for data views in stack rules
(#158431)","sha":"4981f37014829f26514067d2570d7f992c6a76ef","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","docs","backport:prev-minor","v8.9.0"],"number":158431,"url":"https://github.com/elastic/kibana/pull/158431","mergeCommit":{"message":"[DOCS]
Clarify support for data views in stack rules
(#158431)","sha":"4981f37014829f26514067d2570d7f992c6a76ef"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158431","number":158431,"mergeCommit":{"message":"[DOCS]
Clarify support for data views in stack rules
(#158431)","sha":"4981f37014829f26514067d2570d7f992c6a76ef"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants