Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs Onboarding] Adds install shipper step for custom logs #158386

Merged
merged 28 commits into from
May 25, 2023
Merged

[Logs Onboarding] Adds install shipper step for custom logs #158386

merged 28 commits into from
May 25, 2023

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented May 24, 2023 •
edited
Loading

Closes #154937

This PR is an extension of #157802 which was reverted because public Api endpoint versioning problems.

Screenshot 2023-05-15 at 5 02 29 PM

ogupte and others added 25 commits May 15, 2023 16:59
@ogupte
[Logs Onboarding] Adds install shipper step for custom logs (elastic#…
d406d25 
…154937) (WIP)
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
aeb5aaf 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
6571f21 
…fix'
@ogupte
Adds new saved object type observability-onboarding-state
e622f11
@yngrdyn
Generating yaml configuration in server
f394807
@ogupte
Cleans up script and fixes progress updates to be saved in saved objects
6a36ead
@ogupte
set saved objects ids based on apikeyId
dd472c8
@ogupte
- fixed premature API call from wizard when rendered for transition
b3bc425 
- add API to get latest onboarding state
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
aba20b5 
…-ref HEAD~1..HEAD --fix'
@yngrdyn
Merge remote-tracking branch 'origin/logs-onboarding-standalone-elast…
741ad36 
…ic-agent-154937' into logs-onboaring-yaml-generator
@yngrdyn
Using internal savedObjects client
2dce880
@yngrdyn
Merge pull request #7 from ogupte/logs-onboaring-yaml-generator
28bc0fa 
[Logs onboarding] Generating yaml configuration in server
@yngrdyn
Merge remote-tracking branch 'origin/master' into logs-onboarding-sta…
385cc2e 
…ndalone-elastic-agent-154937
@yngrdyn
Merge remote-tracking branch 'origin/master' into logs-onboarding-sta…
0834913 
…ndalone-elastic-agent-154937
@yngrdyn
Fixing build
58c70ac
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
8c8a83a 
…fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/check_mappings_upda…
7eb32a8 
…te --fix'
@ogupte
remove apiKeyId mapping and move progess up one level in saved object…
e559f5e 
… mapping
@ogupte
updated saved object mapping for observability-onboarding-state
678f9bd
@ogupte
uses the static asset path provided for plugins for the downloaded se…
f7d0b44 
…tup script
@ogupte
- adds API that checks for existence of log events for given dataset
e7b8d0d 
- cleans up some routes
@yngrdyn
Fixing build
db0fc5f
@yngrdyn
Merge branch 'main' into logs-onboarding-standalone-elastic-agent-154937
0ed45fe
@yngrdyn
Merge remote-tracking branch 'origin/master' into logs-onboarding-sta…
ee20beb 
…ndalone-elastic-agent-154937
@yngrdyn
Adding version to public api endpoints
ea99b9b
@yngrdyn yngrdyn requested review from a team as code owners May 24, 2023 15:00
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label May 24, 2023
ogupte
ogupte approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. The versioned APIs LGTM.

TinaHeiligers
TinaHeiligers approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mappings and hash updates LGTM.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #50 / machine learning - short tests model management trained models for ML power user with imported models stops deployment of the imported model pt_tiny_zero_shot

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 35.8KB 36.2KB +462.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityOnboarding 4.4KB 4.4KB +50.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 402 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 482 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit b2f0f4e into elastic:main May 25, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 25, 2023
sorenlouv
sorenlouv reviewed Jun 8, 2023
View reviewed changes
x-pack/plugins/observability_onboarding/server/lib/get_authentication_api_key.ts
.split(':');
return {
apiKeyId: apiKey[0],
apiKey: apiKey[1],
Copy link
Member

@sorenlouv sorenlouv Jun 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we discussed this approach with the Kibana security folks to be sure it's blessed? Also: do we have API tests to cover this if platform decides to change anything relating to this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we haven't discussed it since earlier today, but it's worth getting some clarification. Currently not covered by tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we should get API test coverage for all of this before shipping.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue for API tests: #159451

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sorenlouv sorenlouv mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

@sorenlouv sorenlouv sorenlouv left review comments

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs Onboarding] Install shipper: Standalone Elastic Agent
7 participants
@yngrdyn @apmmachine @kibana-ci @sorenlouv @ogupte @TinaHeiligers @kibanamachine