Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Defend workflows] Change license requirement for results #158378

Merged
merged 2 commits into from
May 31, 2023

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented May 24, 2023

By accident we specified wrong RBAC requirement. The proper one should be canReadActionsLogManagement + 'plantinum' license which canAccessEndpointActionsLogManagement meets.

@tomsonpl tomsonpl self-assigned this May 24, 2023
@tomsonpl tomsonpl requested a review from ashokaditya May 31, 2023 09:19
@tomsonpl tomsonpl added v6.8.9 chore release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels May 31, 2023
@tomsonpl tomsonpl marked this pull request as ready for review May 31, 2023 09:20
@tomsonpl tomsonpl requested a review from a team as a code owner May 31, 2023 09:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test for this so if it is changed accidentally the test would fail.

@tomsonpl
Copy link
Contributor Author

@ashokaditya absolutely, the tests are on their way 👍 Since @szwarckonrad and @patrykkopycinski introduced possibility to run kibana with various licenses :elastic-heart: I am able to test it now.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.2MB 9.2MB +10.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 500 504 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

@tomsonpl tomsonpl merged commit f43096a into elastic:main May 31, 2023
@tomsonpl tomsonpl added v8.9.0 and removed v6.8.9 labels May 31, 2023
@kibanamachine kibanamachine added backport:skip This commit does not require backporting labels May 31, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
6.8 Backport failed because of merge conflicts
7.17 Backport failed because of merge conflicts
8.8 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.8:
- [Security Solution][Endpoint] Fix error on security solution UI (#157843)
- [Fleet] Include hidden data streams in package upgrade (#158654)

Manual backport

To create the backport manually run:

node scripts/backport --pr 158378

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants