-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add steps for Docker image verification #158303
Merged
kilfoyle
merged 3 commits into
elastic:main
from
kilfoyle:es96298/container-verification
May 23, 2023
Merged
[DOCS] Add steps for Docker image verification #158303
kilfoyle
merged 3 commits into
elastic:main
from
kilfoyle:es96298/container-verification
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-docs (Team:Docs) |
Documentation preview: |
mgreau
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mistic
approved these changes
May 23, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 23, 2023
This adds steps to the [Install Kibana with Docker](https://www.elastic.co/guide/en/kibana/current/docker.html) page for verifying the downloaded Docker images. I split apart the original version which had all the commands in one block. Having them separate allows us to add in the optional "verify images" step with a link to the Elasticsearch docs for additional info. Rel: elastic/dev#2002 **Preview** ---  ---  --------- Co-authored-by: Tiago Costa <[email protected]> (cherry picked from commit fb9e3c9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 23, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [[DOCS] Add steps for Docker image verification (#158303)](#158303) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"David Kilfoyle","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-23T21:19:29Z","message":"[DOCS] Add steps for Docker image verification (#158303)\n\nThis adds steps to the [Install Kibana with\r\nDocker](https://www.elastic.co/guide/en/kibana/current/docker.html) page\r\nfor verifying the downloaded Docker images. I split apart the original\r\nversion which had all the commands in one block. Having them separate\r\nallows us to add in the optional \"verify images\" step with a link to the\r\nElasticsearch docs for additional info.\r\n\r\nRel: https://github.com/elastic/dev/issues/2002\r\n\r\n**Preview**\r\n\r\n---\r\n\r\n\r\n---\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Tiago Costa <[email protected]>","sha":"fb9e3c9ec80e5ba22b6315b7963ad20caa84f439","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v8.8.0","v8.9.0"],"number":158303,"url":"https://github.com/elastic/kibana/pull/158303","mergeCommit":{"message":"[DOCS] Add steps for Docker image verification (#158303)\n\nThis adds steps to the [Install Kibana with\r\nDocker](https://www.elastic.co/guide/en/kibana/current/docker.html) page\r\nfor verifying the downloaded Docker images. I split apart the original\r\nversion which had all the commands in one block. Having them separate\r\nallows us to add in the optional \"verify images\" step with a link to the\r\nElasticsearch docs for additional info.\r\n\r\nRel: https://github.com/elastic/dev/issues/2002\r\n\r\n**Preview**\r\n\r\n---\r\n\r\n\r\n---\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Tiago Costa <[email protected]>","sha":"fb9e3c9ec80e5ba22b6315b7963ad20caa84f439"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158303","number":158303,"mergeCommit":{"message":"[DOCS] Add steps for Docker image verification (#158303)\n\nThis adds steps to the [Install Kibana with\r\nDocker](https://www.elastic.co/guide/en/kibana/current/docker.html) page\r\nfor verifying the downloaded Docker images. I split apart the original\r\nversion which had all the commands in one block. Having them separate\r\nallows us to add in the optional \"verify images\" step with a link to the\r\nElasticsearch docs for additional info.\r\n\r\nRel: https://github.com/elastic/dev/issues/2002\r\n\r\n**Preview**\r\n\r\n---\r\n\r\n\r\n---\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Tiago Costa <[email protected]>","sha":"fb9e3c9ec80e5ba22b6315b7963ad20caa84f439"}}]}] BACKPORT--> Co-authored-by: David Kilfoyle <[email protected]>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
This adds steps to the [Install Kibana with Docker](https://www.elastic.co/guide/en/kibana/current/docker.html) page for verifying the downloaded Docker images. I split apart the original version which had all the commands in one block. Having them separate allows us to add in the optional "verify images" step with a link to the Elasticsearch docs for additional info. Rel: elastic/dev#2002 **Preview** ---  ---  --------- Co-authored-by: Tiago Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds steps to the Install Kibana with Docker page for verifying the downloaded Docker images. I split apart the original version which had all the commands in one block. Having them separate allows us to add in the optional "verify images" step with a link to the Elasticsearch docs for additional info.
Rel: https://github.com/elastic/dev/issues/2002
Preview