Update saved objects migrations documentation for 8.8.0 #158241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
Team:Core
|
Documentation preview: |
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
approved these changes
May 23, 2023
| @@ -8,34 +8,66 @@ To access the assistant, go to *Stack Management > Upgrade Assistant*. | |||
|
|
|||
| WARNING: {kib} 7.12.0 and later uses a new migration process and index naming scheme. Before you upgrade, read the documentation for your version of {kib}. | |||
|
|
|||
| WARNING: The following instructions assumes {kib} is using the default index names. If the `kibana.index` or `xpack.tasks.index` configuration settings are different from the default, adapt the instructions accordingly. | |||
| WARNING: The `kibana.index` and `xpack.tasks.index` configuration settings are obsolete and no longer taken into account in 8.x. If you are using custom index names, please perform the necessary adaptations before attempting to upgrade to 8.x. | |||
There was a problem hiding this comment.
I think we should remove this warning completely because if you have these config values Kibana will fail to start and there's a separate breaking change notification about this. But it might make sense to do that as a separate PR that we backport to all 8.x versions
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 23, 2023
Documentation must reflect changes brought by the [dot kibana split](elastic#154888). Our public facing documentation just mentions two indices e.g. https://www.elastic.co/guide/en/kibana/8.8/saved-object-migrations.html https://www.elastic.co/guide/en/kibana/8.8/resolve-migrations-failures.html#upgrade-migrations-old-indices this one in particular mentions that "all other indices are safe to delete". (cherry picked from commit 70eb9d3)
kibanamachine
added a commit
that referenced
this pull request
May 23, 2023
… (#158270) # Backport This will backport the following commits from `main` to `8.8`: - [Update saved objects migrations documentation for 8.8.0 (#158241)](#158241) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-23T13:53:52Z","message":"Update saved objects migrations documentation for 8.8.0 (#158241)\n\nDocumentation must reflect changes brought by the [dot kibana\r\nsplit](https://github.com/elastic/kibana/pull/154888).\r\n\r\nOur public facing documentation just mentions two indices e.g.\r\n\r\nhttps://www.elastic.co/guide/en/kibana/8.8/saved-object-migrations.html\r\n\r\nhttps://www.elastic.co/guide/en/kibana/8.8/resolve-migrations-failures.html#upgrade-migrations-old-indices\r\nthis one in particular mentions that \"all other indices are safe to\r\ndelete\".","sha":"70eb9d3ecbb11768d091fca385bad4f20960deef","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","documentation","Feature:Migrations","backport:prev-minor","v8.8.0","v8.9.0","v8.8.1"],"number":158241,"url":"https://github.com/elastic/kibana/pull/158241","mergeCommit":{"message":"Update saved objects migrations documentation for 8.8.0 (#158241)\n\nDocumentation must reflect changes brought by the [dot kibana\r\nsplit](https://github.com/elastic/kibana/pull/154888).\r\n\r\nOur public facing documentation just mentions two indices e.g.\r\n\r\nhttps://www.elastic.co/guide/en/kibana/8.8/saved-object-migrations.html\r\n\r\nhttps://www.elastic.co/guide/en/kibana/8.8/resolve-migrations-failures.html#upgrade-migrations-old-indices\r\nthis one in particular mentions that \"all other indices are safe to\r\ndelete\".","sha":"70eb9d3ecbb11768d091fca385bad4f20960deef"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158241","number":158241,"mergeCommit":{"message":"Update saved objects migrations documentation for 8.8.0 (#158241)\n\nDocumentation must reflect changes brought by the [dot kibana\r\nsplit](https://github.com/elastic/kibana/pull/154888).\r\n\r\nOur public facing documentation just mentions two indices e.g.\r\n\r\nhttps://www.elastic.co/guide/en/kibana/8.8/saved-object-migrations.html\r\n\r\nhttps://www.elastic.co/guide/en/kibana/8.8/resolve-migrations-failures.html#upgrade-migrations-old-indices\r\nthis one in particular mentions that \"all other indices are safe to\r\ndelete\".","sha":"70eb9d3ecbb11768d091fca385bad4f20960deef"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <[email protected]>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
Documentation must reflect changes brought by the [dot kibana split](elastic#154888). Our public facing documentation just mentions two indices e.g. https://www.elastic.co/guide/en/kibana/8.8/saved-object-migrations.html https://www.elastic.co/guide/en/kibana/8.8/resolve-migrations-failures.html#upgrade-migrations-old-indices this one in particular mentions that "all other indices are safe to delete".
rudolf
added
the
Epic:ScaleMigrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation must reflect changes brought by the dot kibana split.
Our public facing documentation just mentions two indices e.g.
https://www.elastic.co/guide/en/kibana/8.8/saved-object-migrations.html
https://www.elastic.co/guide/en/kibana/8.8/resolve-migrations-failures.html#upgrade-migrations-old-indices this one in particular mentions that "all other indices are safe to delete".