Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build_date to kbn:api/status #157905

Merged
merged 19 commits into from
May 25, 2023

Conversation

Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented May 16, 2023

Summary

Adds build date to GET kbn:api/status similar to ES. Example output running locally:

{
  "name": "ES-DMVD5M3",
  "uuid": "545ba70c-063e-449b-af21-6c8e7b30f77e",
  "version": {
    "number": "8.9.0",
    "build_hash": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
    "build_number": 9007199254740991,
    "build_snapshot": false,
    "build_date": "2023-05-15T23:12:09.000Z"
  },
  ...rest
}

Checklist

Release Note

The status endpoint now returns the build date alongside other build information.

@Ikuni17 Ikuni17 requested review from a team as code owners May 16, 2023 16:52
@Ikuni17 Ikuni17 self-assigned this May 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@github-actions
Copy link
Contributor

Documentation preview:

@Ikuni17 Ikuni17 requested a review from a team as a code owner May 16, 2023 18:41
@Ikuni17 Ikuni17 requested review from pgayvallet and jbudz May 17, 2023 16:36
@Ikuni17
Copy link
Contributor Author

Ikuni17 commented May 22, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/config 44 45 +1
@kbn/core-status-common-internal 18 19 +1
total +2
Unknown metric groups

API count

id before after diff
@kbn/config 73 74 +1
@kbn/core-status-common-internal 19 20 +1
total +2

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 403 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 483 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Ikuni17

@Ikuni17
Copy link
Contributor Author

Ikuni17 commented May 23, 2023

@elastic/kibana-reporting-services Can we get a code review on this PR please?

@Ikuni17 Ikuni17 merged commit 0c3ca36 into elastic:main May 25, 2023
@Ikuni17 Ikuni17 deleted the feature/add-kbn-status-build-date branch May 25, 2023 17:21
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 25, 2023
@watson watson removed the backport label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Operations Team label for Operations Team v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants