[UnifiedFieldList] Move routes to internal #157893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
changed the title
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @jughosta |
jughosta
added
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
lukasolson
approved these changes
May 16, 2023
kertal
reviewed
May 17, 2023
| @@ -11,6 +11,9 @@ import { PluginStart } from '../types'; | |||
| import { existingFieldsRoute } from './existing_fields'; | |||
| import { initFieldStatsRoute } from './field_stats'; | |||
|
|
|||
| // These routes are defined only for running integration tests under | |||
There was a problem hiding this comment.
QQ: Do we even need this routes, if the only clients are integration tests but they are not used in the UI?
There was a problem hiding this comment.
@kertal Once we find a replacement for those tests, we can remove routes.
2 tasks
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
Closes elastic#157081 ## Summary Moving routes to `internal` namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157081
Summary
Moving routes to
internalnamespace.