Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infrastructure UI] Clean dead code after saved objects migration #156158

Merged
merged 50 commits into from
May 4, 2023
Merged

[Infrastructure UI] Clean dead code after saved objects migration #156158

merged 50 commits into from
May 4, 2023

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Apr 28, 2023 •
edited
Loading

📓 Summary

Closes #155117
Closes #152617

This PR removes all the legacy code unused for handling the saved views client logic.

Marco Antonio Ghiani and others added 30 commits April 19, 2023 20:09
feat(infra): wip useInventoryViews
7b488c3
feat(infra): extract react query config
7228a31
feat(infra): wip useInventoryViews mutations
34e8571
refactor(infra): remove currentView placeholder
54a5172
@tonyghiani
Merge branch 'main' into 154725-create-saved-views-hooks
a6b3809
refactor(infra): update types
a76f79a
@tonyghiani
Merge branch 'main' into 154725-create-saved-views-hooks
4fd307b
refactor(infra): finalize types
5f65776
@tonyghiani
Merge branch 'main' into 154725-create-saved-views-hooks
f3f18a9
feat(infra): use new useInventoryView hook
d23b773
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
c95eed3 
…-ref HEAD~1..HEAD --fix'
fix(infra): update insertion logic for view
f1ff109
fix(infra): wait to update source
8d150fa
Merge branch '154725-create-saved-views-hooks' of github.com:tonyghia…
8f86912 
…ni/kibana into 154725-create-saved-views-hooks
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
b3265ca 
…fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
d597acf 
…-fix'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
5de74e8 
…fix'
@tonyghiani
Merge branch 'main' into 154725-create-saved-views-hooks
08d7b49
feat(infra): update typing Inventory Views
ac20959
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
9cc2345 
…-ref HEAD~1..HEAD --fix'
feat(infra): add useMetricsExplorerViews hook
a164def
feat(infra): refine types for metrics views
38edf9b
@tonyghiani
Merge branch 'main' into 154725-create-saved-views-hooks
cd974bd
fix(infra): types
b0b9f03
tests(infra): remove legacy tests
4092e28
tests(infra): remove exclusive tests
4cfe534
refactor(translation): remove unused translations
5a88bef
refactor(translation): update toolbar types
78df44d
refactor(infra): switch to icon button for better alignment
d55002f
refactor(infra): update test
ee872cd
@tonyghiani tonyghiani added the release_note:skip Skip the PR/issue when compiling release notes label Apr 28, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tonyghiani tonyghiani force-pushed the 155117-cleanup-client-saved-objects branch from d870b6f to ee6276a Compare May 2, 2023 07:21
@tonyghiani tonyghiani force-pushed the 155117-cleanup-client-saved-objects branch from 16de1db to 8a3f695 Compare May 2, 2023 09:38
@tonyghiani tonyghiani force-pushed the 155117-cleanup-client-saved-objects branch from 8a3f695 to 6ab5560 Compare May 2, 2023 13:30
@tonyghiani tonyghiani marked this pull request as ready for review May 2, 2023 13:34
@tonyghiani tonyghiani requested a review from a team as a code owner May 2, 2023 13:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@crespocarlos crespocarlos self-requested a review May 4, 2023 10:45
crespocarlos
crespocarlos approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🧹

@tonyghiani tonyghiani enabled auto-merge (squash) May 4, 2023 10:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

References to deprecated APIs

id before after diff
infra 102 59 -43

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tonyghiani tonyghiani merged commit 56fa5b9 into elastic:main May 4, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 4, 2023
@tonyghiani tonyghiani deleted the 155117-cleanup-client-saved-objects branch July 13, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.9.0
Projects
None yet
Milestone
No milestone
6 participants
@tonyghiani @apmmachine @elasticmachine @kibana-ci @crespocarlos @kibanamachine