Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add functional testing for continuous transforms (creation, start, stop, reset) #156128

Merged
merged 10 commits into from
May 3, 2023
Merged

[ML] Add functional testing for continuous transforms (creation, start, stop, reset) #156128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
646fadc
Add continuous transform testing (creation, start, stop, reset)
qn895 Apr 27, 2023
19f0096
Merge remote-tracking branch 'upstream/main' into ml-transform-contin…
qn895 Apr 27, 2023
2f64036
Clean up duplicate func and fullTimeRange
qn895 Apr 28, 2023
55acc06
Stabilize creation_index_pattern tests
qn895 Apr 28, 2023
be2e4e1
Fix based on comments
qn895 Apr 28, 2023
1fbf8b8
Add better check for reset
qn895 Apr 28, 2023
5390e99
Add better check for reset
qn895 Apr 28, 2023
7d018f9
Merge branch 'main' into ml-transform-continuous-functional-test
kibanamachine May 3, 2023
d414308
Fix jest tests
qn895 May 3, 2023
d56942d
Merge remote-tracking branch 'upstream/main' into ml-transform-contin…
qn895 May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nsform/public/app/sections/create_transform/components/step_details/step_details_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ export const StepDetailsForm: FC<StepDetailsFormProps> = React.memo(
)}
>
<EuiSelect
options={dateFieldNames.map((text: string) => ({ text }))}
options={dateFieldNames.map((text: string) => ({ text, value: text }))}
value={continuousModeDateField}
onChange={(e) => setContinuousModeDateField(e.target.value)}
data-test-subj="transformContinuousDateFieldSelect"
Expand Down
2 changes: 1 addition & 1 deletion .../public/app/sections/transform_management/components/transform_list/expanded_row.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe('Transform: Transform List <ExpandedRow />', () => {

await waitFor(() => {
expect(screen.getByTestId('transformStatsTab')).toHaveAttribute('aria-selected', 'true');
const tabContent = screen.getByTestId('transformDetailsTabContent');
const tabContent = screen.getByTestId('transformStatsTabContent');
expect(within(tabContent).getByText('Stats')).toBeInTheDocument();
});
});
Expand Down
5 changes: 4 additions & 1 deletion ...sform/public/app/sections/transform_management/components/transform_list/expanded_row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ export const ExpandedRow: FC<Props> = ({ item, onAlertEdit }) => {
checkpointing,
...(alertingRules.items ? [alertingRules] : []),
]}
dataTestSubj={'transformDetailsTabContent'}
/>
),
},
Expand All @@ -252,7 +253,9 @@ export const ExpandedRow: FC<Props> = ({ item, onAlertEdit }) => {
defaultMessage: 'Stats',
}
),
content: <ExpandedRowDetailsPane sections={[stats]} />,
content: (
<ExpandedRowDetailsPane sections={[stats]} dataTestSubj={'transformStatsTabContent'} />
),
},
{
id: `transform-json-tab-${tabId}`,
Expand Down
8 changes: 6 additions & 2 deletions ...app/sections/transform_management/components/transform_list/expanded_row_details_pane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,15 @@ export const Section: FC<SectionProps> = ({ section }) => {

interface ExpandedRowDetailsPaneProps {
sections: SectionConfig[];
dataTestSubj?: string;
}

export const ExpandedRowDetailsPane: FC<ExpandedRowDetailsPaneProps> = ({ sections }) => {
export const ExpandedRowDetailsPane: FC<ExpandedRowDetailsPaneProps> = ({
sections,
dataTestSubj,
}) => {
return (
<div data-test-subj="transformDetailsTabContent">
<div data-test-subj={dataTestSubj ?? 'transformDetailsTabContent'}>
<EuiFlexGroup>
<EuiFlexItem style={{ width: '50%' }}>
{sections
Expand Down
Loading