Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] AIOps: Stabilize flaky functional tests. #155710

Merged

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Apr 25, 2023

Summary

Fixes #155222.

Stabilize flaky functional tests: Empty the query input before adding new content and retry, don't assert results for runs with random sampling being triggered.

Checklist

@walterra walterra self-assigned this Apr 25, 2023
@walterra walterra added the release_note:skip Skip the PR/issue when compiling release notes label Apr 25, 2023
@walterra
Copy link
Contributor Author

walterra commented Apr 25, 2023

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2165

🔴 still flaky

@walterra
Copy link
Contributor Author

walterra commented Apr 25, 2023

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2166

🔴 the query input seems fixed but some grouping assertions with sampling are still flaky

@walterra
Copy link
Contributor Author

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2168

🟢 100 runs passed!

@walterra walterra marked this pull request as ready for review April 25, 2023 17:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

await aiops.logPatternAnalysisPageProvider.assertQueryInput(
testData.action.expected.queryBar
);
}
}
});
}

// FLAKY: https://github.com/elastic/kibana/issues/155222
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can probably remove this FLAKY line before merging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, removed in 2a4b75a. 👍

@qn895
Copy link
Member

qn895 commented Apr 25, 2023

LGTM 🎉

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 396 399 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 476 479 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit f2a0ee4 into elastic:main Apr 26, 2023
@walterra walterra deleted the ml-155222-stabilize-aiops-functional-test branch April 26, 2023 08:02
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 26, 2023
@elastic elastic deleted a comment from kibanamachine Apr 26, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 26, 2023
* main: (1294 commits)
  [SecuritySolution] Refactor security packages (elastic#155365)
  [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717)
  [RAM] Conditional actions feedback on pr review (elastic#155804)
  [Files] Adds bulk delete method (elastic#155628)
  [Lens] Use proper way to generate absolute short URL (elastic#155512)
  [Guided onboarding] Use Kibana features to grant access (elastic#155065)
  [Index Management] Fix duped mock (elastic#155844)
  [Lens] Enhance visualization modifier popup with layer palette (elastic#155280)
  Fix flaky combobox tests on role management screen (elastic#155711)
  [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126)
  [Fleet] always create agent upload write indices (elastic#155729)
  [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045)
  Add tech preview label for search applications (elastic#155649)
  [ML] AIOps: Stabilize flaky functional tests. (elastic#155710)
  [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610)
  [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814)
  [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800)
  Remove Exploratory View components from Observability (elastic#155629)
  [Discover] Remove redundant "Filter was added" toast (elastic#155645)
  [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
6 participants