[Cases] Disable deletion of cases files in stack mgmt. #155683

adcoelho · 2023-04-25T06:26:14Z

Summary

Since #155179 was merged we can now disable the deletion of Cases files in the Files page in Stack management.

Screen.Recording.2023-04-25.at.08.22.27.mov

elasticmachine · 2023-04-25T06:26:17Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2023-04-25T06:26:18Z

Pinging @elastic/response-ops-cases (Feature:Cases)

js-jankisalvi

Verified locally, looks good 👍

x-pack/plugins/cases/public/files/index.ts

jonathan-buttner · 2023-04-25T12:33:32Z

x-pack/plugins/cases/public/files/index.ts

+    managementUiActions: {
+      delete: {
+        enabled: false,
+        reason: 'File is managed by Cases',


We'll need to translate this message and I wonder if it'd be better to state that the user needs to go to cases to delete the file rather than just saying it's managed by cases. I wonder if we should also include the plugin name here?

@lcawl What do you think? This reason field will show up when a user hovers over a disabled checkbox in the file management page for a cases file. Is this text sufficient for communicating that the user will need to navigate to cases to delete the file? Or maybe we should have something like: Navigate to <Security|Observability|Management> Cases to delete this file

szabosteve

I left a suggestion, otherwise UI text LGTM. I think it's better to communicate clearly what the user needs to do to delete the file – even if it slightly increases the word count.

szabosteve · 2023-04-25T13:52:32Z

x-pack/plugins/cases/public/files/index.ts

+    managementUiActions: {
+      delete: {
+        enabled: false,
+        reason: 'File is managed by Cases',


Suggested change

reason: 'File is managed by Cases',

reason: 'This file is managed by Cases. Navigate to the Cases page under Stack management to delete it.',

I talked to @szabosteve offline and since the file might exist in a different plugin he suggested something like this:

This file is managed by Cases. Navigate to the Cases page under <Security or Observability or Stack Management> to delete it.

cnasikas · 2023-04-25T15:12:08Z

x-pack/plugins/cases/common/constants/owners.ts

@@ -17,6 +17,19 @@ export const GENERAL_CASES_OWNER = APP_ID;

 export const OWNERS = [GENERAL_CASES_OWNER, OBSERVABILITY_OWNER, SECURITY_SOLUTION_OWNER] as const;

+export const getOwnerUIName = (owner: Owner) => {


The OWNER_INFO contains an attribute called label. Maybe we can use it. The names are a bit different but we can change it to match what you have here. They are being shown in the case flyout and in the cases modal.

I noticed those but, what is this OWNER_INFO used for? Is it safe to just extend?

…on-outside-cases

jonathan-buttner · 2023-04-25T16:54:36Z

x-pack/plugins/cases/public/files/index.ts

+const getOwnerUIName = (owner: Owner) => {
+  switch (owner) {
+    case SECURITY_SOLUTION_OWNER:
+      return 'Security Solution';


Sorry to nitpick this, Security Solution is an internal name I think. I believe in the external docs we refer to it as Elastic Security https://www.elastic.co/guide/en/security/current/es-ui-overview.html#es-ui-overview

How about we change this to return 'Elastic Security'? or maybe return 'Security'

jonathan-buttner · 2023-04-25T18:55:26Z

packages/kbn-optimizer/limits.yml

@@ -7,7 +7,7 @@ pageLoadAssetSize:
  banners: 17946
  bfetch: 22837
  canvas: 1066647
-  cases: 170000
+  cases: 175000


I'm temporarily raising the bundle size here so we can get this merged. We still have this issue: #103748 and we're planning on working on it. We'd just like to get this PR merged in 8.8 and we won't be able to realistically lower the bundle size in this release.

jbudz

limits.yml

kibana-ci · 2023-04-25T20:01:56Z

💚 Build Succeeded

Buildkite Build
Commit: 52ee498

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cases`	618	619	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	165.9KB	166.3KB	+370.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	17	19	+2
`securitySolution`	397	400	+3
total			+5

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	18	20	+2
`securitySolution`	477	480	+3
total			+5

History

💔 Build #123063 failed f6886c2
💚 Build #122913 succeeded 6b16f37
💚 Build #122854 succeeded 35affaec169e28671285532223e89cffa14ace96
💚 Build #122792 succeeded 1517a4ecde1f62bdd12a2d97a6add7c794885e3a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

adcoelho added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.8.0 labels Apr 25, 2023

adcoelho self-assigned this Apr 25, 2023

adcoelho requested a review from a team as a code owner April 25, 2023 06:26

js-jankisalvi approved these changes Apr 25, 2023

View reviewed changes

cnasikas reviewed Apr 25, 2023

View reviewed changes

x-pack/plugins/cases/public/files/index.ts Show resolved Hide resolved

adcoelho added 3 commits April 25, 2023 13:34

Disable deletion of cases files in stack mgmt.

48a496b

Addressing PR comments.

2d61d4e

Change phrasing in file deletion reason

6b16f37

adcoelho force-pushed the disable-file-deletion-outside-cases branch from 35affae to 6b16f37 Compare April 25, 2023 11:34

jonathan-buttner reviewed Apr 25, 2023

View reviewed changes

szabosteve approved these changes Apr 25, 2023

View reviewed changes

Change file delete reason text.

fd01f0c

cnasikas reviewed Apr 25, 2023

View reviewed changes

adcoelho force-pushed the disable-file-deletion-outside-cases branch from 3a8799b to f2b8a09 Compare April 25, 2023 15:18

Merge remote-tracking branch 'upstream/main' into disable-file-deleti…

f6886c2

…on-outside-cases

adcoelho force-pushed the disable-file-deletion-outside-cases branch from f2b8a09 to f6886c2 Compare April 25, 2023 15:19

jonathan-buttner reviewed Apr 25, 2023

View reviewed changes

Temporarily raising the bundle limit

3184c8f

jonathan-buttner requested a review from a team as a code owner April 25, 2023 18:53

jonathan-buttner reviewed Apr 25, 2023

View reviewed changes

jbudz approved these changes Apr 25, 2023

View reviewed changes

Using Security for string

52ee498

jonathan-buttner enabled auto-merge (squash) April 25, 2023 18:56

jonathan-buttner merged commit 933bca2 into elastic:main Apr 25, 2023

kibanamachine added the backport:skip This commit does not require backporting label Apr 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] Disable deletion of cases files in stack mgmt. #155683

[Cases] Disable deletion of cases files in stack mgmt. #155683

adcoelho commented Apr 25, 2023

elasticmachine commented Apr 25, 2023

elasticmachine commented Apr 25, 2023

js-jankisalvi left a comment

jonathan-buttner Apr 25, 2023

szabosteve left a comment

szabosteve Apr 25, 2023

jonathan-buttner Apr 25, 2023

cnasikas Apr 25, 2023

adcoelho Apr 25, 2023

jonathan-buttner Apr 25, 2023 •

edited

Loading

jonathan-buttner Apr 25, 2023

jbudz left a comment

kibana-ci commented Apr 25, 2023

ESLint disabled line counts

Total ESLint disabled count

	reason: 'File is managed by Cases',
	reason: 'This file is managed by Cases. Navigate to the Cases page under Stack management to delete it.',

		@@ -17,6 +17,19 @@ export const GENERAL_CASES_OWNER = APP_ID;

		export const OWNERS = [GENERAL_CASES_OWNER, OBSERVABILITY_OWNER, SECURITY_SOLUTION_OWNER] as const;

		export const getOwnerUIName = (owner: Owner) => {

[Cases] Disable deletion of cases files in stack mgmt. #155683

[Cases] Disable deletion of cases files in stack mgmt. #155683

Conversation

adcoelho commented Apr 25, 2023

Summary

elasticmachine commented Apr 25, 2023

elasticmachine commented Apr 25, 2023

js-jankisalvi left a comment

Choose a reason for hiding this comment

jonathan-buttner Apr 25, 2023

Choose a reason for hiding this comment

szabosteve left a comment

Choose a reason for hiding this comment

szabosteve Apr 25, 2023

Choose a reason for hiding this comment

jonathan-buttner Apr 25, 2023

Choose a reason for hiding this comment

cnasikas Apr 25, 2023

Choose a reason for hiding this comment

adcoelho Apr 25, 2023

Choose a reason for hiding this comment

jonathan-buttner Apr 25, 2023 • edited Loading

Choose a reason for hiding this comment

jonathan-buttner Apr 25, 2023

Choose a reason for hiding this comment

jbudz left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 25, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

jonathan-buttner Apr 25, 2023 •

edited

Loading