Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AO] Add threshold information to the metric threshold alert details page #155493

Merged
merged 8 commits into from
Apr 25, 2023

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Apr 21, 2023

Closes #153740, closes #153833, closes #155593

This PR adds threshold information and rule name to the metric threshold alert details page.

image

🧪 How to test

  • Add xpack.observability.unsafe.alertDetails.metrics.enabled: true to the Kibana config
  • Create a metric threshold rule with multiple conditions that generates an alert
  • Go to the alert details page and check threshold information
  • Click on the rule link; it should send you to the rule page

@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Apr 21, 2023
@maryam-saeidi maryam-saeidi self-assigned this Apr 21, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi maryam-saeidi changed the title 153740 add threshold [AO] Add threshold information to the metric threshold alert details page Apr 21, 2023
@maryam-saeidi maryam-saeidi marked this pull request as ready for review April 21, 2023 11:51
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner April 21, 2023 11:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi added the Feature:Alert Details Page Observability ux management team label Apr 21, 2023
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner April 24, 2023 10:11
Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, LGTM !

</div>
{!hideTitle && (
<div style={{ textAlign: 'center' }}>
{series.id !== 'ALL' ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe extracting this would make it easier to read?

@maryam-saeidi maryam-saeidi enabled auto-merge (squash) April 25, 2023 08:32
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1356 1357 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB +2.6KB
observability 1.1MB 1.1MB +66.0B
total +2.6KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 396 399 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 476 479 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit dfea483 into elastic:main Apr 25, 2023
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Apr 25, 2023
@maryam-saeidi maryam-saeidi deleted the 153740-add-threshold branch April 25, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alert Details Page Observability ux management team release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
7 participants