-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AO] Add threshold information to the metric threshold alert details page #155493
[AO] Add threshold information to the metric threshold alert details page #155493
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, LGTM !
x-pack/plugins/infra/common/alerting/metrics/metric_value_formatter.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/common/alerting/metrics/metric_value_formatter.ts
Outdated
Show resolved
Hide resolved
</div> | ||
{!hideTitle && ( | ||
<div style={{ textAlign: 'center' }}> | ||
{series.id !== 'ALL' ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe extracting this would make it easier to read?
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Closes #153740, closes #153833, closes #155593
This PR adds threshold information and rule name to the metric threshold alert details page.
🧪 How to test