Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide remote indices role configuration when not supported #155490

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Hide remote indices role configuration when not supported #155490

merged 1 commit into from
Apr 21, 2023

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Apr 21, 2023 •
edited
Loading

Resolves #155389

Summary

Adds feature flag to automatically hide remote index privileges section when not supported by cluster.

@thomheymann thomheymann added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Apr 21, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 563.1KB 563.4KB +263.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomheymann thomheymann marked this pull request as ready for review April 21, 2023 12:24
@thomheymann thomheymann requested a review from a team as a code owner April 21, 2023 12:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kc13greiner kc13greiner self-requested a review April 21, 2023 12:38
kc13greiner
kc13greiner approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomheymann thomheymann merged commit cfc01d5 into elastic:main Apr 21, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kc13greiner kc13greiner kc13greiner approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide RCS 2.0 role configuration
5 participants
@thomheymann @kibana-ci @elasticmachine @kc13greiner @kibanamachine