Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security Posture][CNVM] UI Fixes/Enhancements #155473

Merged
merged 9 commits into from
Apr 21, 2023
Merged

[Cloud Security Posture][CNVM] UI Fixes/Enhancements #155473

merged 9 commits into from
Apr 21, 2023

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Apr 21, 2023 •
edited
Loading

Summary

This PR addresses Fixes and Enhancements for Cloud Native Vulnerability Management, such as:

  • Added Billing usage Callout
  • Fixed Badges Inconsistency between the Table and the Flyout
  • Added support for custom placeholder in the Search Bar
  • Added Filter In/Out option in the Table
  • Fixed Published Date was always showing today's date
  • Added filter to the table to filter out inconsistent data
  • Improved types in the useLatestVulnerabilities hook
  • Cleaned the Fix version column when there were no fixes available
  • Changed score to always display in decimals for consistency
  • Reduced vulnerability column default width (still resizable)

Screenshots

Billing usage Callout

image

Filters

image

Filter In

image

Filter Out

image

Flyout

image

Score always in decimals

image

@opauloh opauloh changed the title [Cloud Security Posture][CNVM] UI Enhancements [Cloud Security Posture][CNVM] UI Fixes/Enhancements Apr 21, 2023
@opauloh opauloh marked this pull request as ready for review April 21, 2023 04:38
@opauloh opauloh requested a review from a team as a code owner April 21, 2023 04:38
@opauloh opauloh added the release_note:skip Skip the PR/issue when compiling release notes label Apr 21, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 163 165 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 186.9KB 190.1KB +3.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 11.6KB 11.6KB +43.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This was linked to issues Apr 21, 2023
[Cloud Security] [Vulnerability Management] Add Vulnerability Management integration UI extension #150485
Closed
[Cloud Posture] [Vulnerability Management] Add cell filters to findings table #155172
Closed
@opauloh opauloh enabled auto-merge (squash) April 21, 2023 05:58
@opauloh opauloh added Team:Cloud Security Cloud Security team related v8.8.0 labels Apr 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@opauloh opauloh requested a review from animehart April 21, 2023 06:35
@opauloh opauloh merged commit e0d40b7 into elastic:main Apr 21, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 21, 2023
kfirpeled
kfirpeled reviewed Apr 23, 2023
View reviewed changes
x-pack/plugins/cloud_security_posture/common/constants.ts
@@ -75,6 +75,7 @@ export const CLOUDBEAT_VULN_MGMT_AZURE = 'cloudbeat/vuln_mgmt_azure';
export const KSPM_POLICY_TEMPLATE = 'kspm';
export const CSPM_POLICY_TEMPLATE = 'cspm';
export const VULN_MGMT_POLICY_TEMPLATE = 'vuln_mgmt';
export const CNVM_POLICY_TEMPLATE = 'cnvm';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this constant name is missleading because there no CNVM policy template

...gins/cloud_security_posture/public/components/fleet_extensions/policy_template_selectors.tsx
Comment on lines +30 to +33
if (policyTemplate === VULN_MGMT_POLICY_TEMPLATE) {
return CNVM_POLICY_TEMPLATE.toUpperCase();
}
return policyTemplate.toUpperCase();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use localized strings whenever we display text to our users

Lets map these codes to their relevant text instead of using technical text to display to the user

...gins/cloud_security_posture/public/components/fleet_extensions/policy_template_selectors.tsx
title={
<FormattedMessage
id="xpack.csp.fleetIntegration.cnvm.additionalChargesCalloutTitle"
defaultMessage="Additional charges on cloud provider billing account."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

design suggests this without a period Additional charges on cloud provider billing account

...gins/cloud_security_posture/public/components/fleet_extensions/policy_template_selectors.tsx
<p>
<FormattedMessage
id="xpack.csp.fleetIntegration.cnvm.additionalChargesCalloutDescription"
defaultMessage="Please note that using this service may result in additional charges on your next cloud provider billing statement due to increased usage."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

design suggests

- defaultMessage="Please note that using this service may result in additional charges on your next cloud provider billing statement due to increased usage."
+ defaultMessage="Please note that using this service may result in additional charges on your next cloud provider billing statement due to increased usage for scanning"

@kfirpeled kfirpeled mentioned this pull request Apr 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled left review comments

@tehilashn tehilashn tehilashn approved these changes

@Omolola-Akinleye Omolola-Akinleye Awaiting requested review from Omolola-Akinleye

@JordanSh JordanSh Awaiting requested review from JordanSh

@animehart animehart Awaiting requested review from animehart

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.8.0
Projects
None yet
Milestone
No milestone
6 participants
@opauloh @kibana-ci @elasticmachine @kfirpeled @tehilashn @kibanamachine