[Defend Workflows][E2E]Endpoint isolate e2e coverage multipass backport #155360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # x-pack/plugins/security_solution/common/endpoint/index_data.ts
# Conflicts: # x-pack/plugins/security_solution/public/management/cypress/support/data_loaders.ts # x-pack/plugins/security_solution/public/management/cypress/support/plugin_handlers/endpoint_data_loader.ts # x-pack/plugins/security_solution/public/management/cypress/tasks/index_endpoint_hosts.ts # x-pack/plugins/security_solution/scripts/endpoint/agent_emulator/services/endpoint_response_actions.ts
# Conflicts: # x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts
szwarckonrad
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
szwarckonrad
changed the title
|
This is awesome, good job! 👍 |
tomsonpl
reviewed
Apr 21, 2023
| @@ -115,6 +118,12 @@ declare global { | |||
| arg: IndexedEndpointPolicyResponse, | |||
| options?: Partial<Loggable & Timeoutable> | |||
| ): Chainable<null>; | |||
|
|
|||
There was a problem hiding this comment.
Why do we have a d.ts file? Can't we keep configuration like here in osquery? https://github.com/elastic/kibana/blob/ef375b4073983cc271a0e32ba08e719d36abd8fa/x-pack/plugins/osquery/cypress/support/e2e.ts
tomsonpl
reviewed
Apr 21, 2023
| 'Linux', | ||
| '10.138.79.131, 10.170.160.154', | ||
| '10.56.228.101, 10.201.120.140,10.236.180.146', |
There was a problem hiding this comment.
Can you briefly explain what is the purpose of this? Is this autogenerated?
There was a problem hiding this comment.
These are autogenerated and change every time we update document generator. This is not part of this PR though ;)
tomsonpl
approved these changes
Apr 21, 2023
# Conflicts: # x-pack/plugins/security_solution/public/management/cypress/e2e/mocked_data/isolate.cy.ts # x-pack/plugins/security_solution/public/management/cypress/tasks/isolate.ts
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
approved these changes
Apr 25, 2023
szwarckonrad
added a commit
that referenced
this pull request
Apr 27, 2023
This PR adds e2e test run on real endpoint for coverage of isolate, processes, kill-process and suspend-process commands from respond console. Depends on #155360
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 27, 2023
…ic#155519) This PR adds e2e test run on real endpoint for coverage of isolate, processes, kill-process and suspend-process commands from respond console. Depends on elastic#155360 (cherry picked from commit d80fdd6)
kibanamachine
referenced
this pull request
May 2, 2023
…155519) (#155975) # Backport This will backport the following commits from `main` to `8.8`: - [[Defend Workflows][E2E]Endpoint e2e response console multipass (#155519)](#155519) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T08:27:21Z","message":"[Defend Workflows][E2E]Endpoint e2e response console multipass (#155519)\n\nThis PR adds e2e test run on real endpoint for coverage of isolate,\r\nprocesses, kill-process and suspend-process commands from respond\r\nconsole.\r\n\r\nDepends on https://github.com/elastic/kibana/pull/155360","sha":"d80fdd6bceec438cae572ba13eae3ee3a9d3c5c3","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","v8.8.0","v8.9.0"],"number":155519,"url":"https://github.com/elastic/kibana/pull/155519","mergeCommit":{"message":"[Defend Workflows][E2E]Endpoint e2e response console multipass (#155519)\n\nThis PR adds e2e test run on real endpoint for coverage of isolate,\r\nprocesses, kill-process and suspend-process commands from respond\r\nconsole.\r\n\r\nDepends on https://github.com/elastic/kibana/pull/155360","sha":"d80fdd6bceec438cae572ba13eae3ee3a9d3c5c3"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155519","number":155519,"mergeCommit":{"message":"[Defend Workflows][E2E]Endpoint e2e response console multipass (#155519)\n\nThis PR adds e2e test run on real endpoint for coverage of isolate,\r\nprocesses, kill-process and suspend-process commands from respond\r\nconsole.\r\n\r\nDepends on https://github.com/elastic/kibana/pull/155360","sha":"d80fdd6bceec438cae572ba13eae3ee3a9d3c5c3"}}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <[email protected]> Co-authored-by: Patryk Kopyciński <[email protected]>
ashokaditya
added a commit
to ashokaditya/kibana
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #154465
This PR backports
isolatecommand e2e tests to be used with multipass.