[Security Solution] Remove index false from artifact saved objects mappings #155204
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,36 +14,31 @@ export const exceptionsArtifactSavedObjectType = ArtifactConstants.SAVED_OBJECT_ | |
| export const manifestSavedObjectType = ManifestConstants.SAVED_OBJECT_TYPE; | ||
|
|
||
| export const exceptionsArtifactSavedObjectMappings: SavedObjectsType['mappings'] = { | ||
| dynamic: false, | ||
| properties: { | ||
| identifier: { | ||
| type: 'keyword', | ||
| }, | ||
| compressionAlgorithm: { | ||
| type: 'keyword', | ||
| }, | ||
| encryptionAlgorithm: { | ||
| type: 'keyword', | ||
| }, | ||
| encodedSha256: { | ||
| type: 'keyword', | ||
| }, | ||
| encodedSize: { | ||
| type: 'long', | ||
| }, | ||
| decodedSha256: { | ||
| type: 'keyword', | ||
| }, | ||
| decodedSize: { | ||
| type: 'long', | ||
| }, | ||
| created: { | ||
| type: 'date', | ||
| }, | ||
| body: { | ||
| type: 'binary', | ||
|
|
@@ -52,28 +47,25 @@ export const exceptionsArtifactSavedObjectMappings: SavedObjectsType['mappings'] | |
| }; | ||
|
|
||
| export const manifestSavedObjectMappings: SavedObjectsType['mappings'] = { | ||
| dynamic: false, | ||
| properties: { | ||
| created: { | ||
| type: 'date', | ||
|
There was a problem hiding this comment. I didn't see an explanation in the comments/PR so I'll ask here: why are we adding mappings for these fields, when they previously weren't needed? These mappings can be added at any point in the future, but this is our last opportunity to remove anything unnecessarily indexed (or specified to not be indexed). There was a problem hiding this comment. @rylnd apologies - I was doing some smoke testing locally with the fields removed first. All looks OK, so I pushed up the changes. |
||
| }, | ||
| schemaVersion: { | ||
| type: 'keyword', | ||
| }, | ||
| semanticVersion: { | ||
| type: 'keyword', | ||
| }, | ||
| artifacts: { | ||
| type: 'nested', | ||
| properties: { | ||
| policyId: { | ||
| type: 'keyword', | ||
| }, | ||
| artifactId: { | ||
| type: 'keyword', | ||
| }, | ||
| }, | ||
| }, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this SO type (
endpoint:user-artifact) is actually one we no longer use and have an issue open to remove it (team issue 6214), so whatever changes you want to do here, you canThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paul-tavares I went ahead and removed the SO here: 19d06c7