Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Use PageObject service methods to fix flaky test #155161

Merged
merged 1 commit into from
Apr 18, 2023
Merged

[Maps] Use PageObject service methods to fix flaky test #155161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions x-pack/test/accessibility/apps/maps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const inspector = getService('inspector');
const PageObjects = getPageObjects(['common', 'settings', 'header', 'home', 'maps']);

// Failing: See https://github.com/elastic/kibana/issues/154913
describe.skip('Maps app Accessibility', () => {
describe('Maps app Accessibility', () => {
before(async () => {
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
useActualUrl: true,
Expand Down Expand Up @@ -79,12 +78,12 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

it('full screen button should exist', async () => {
await testSubjects.click('mapsFullScreenMode');
await PageObjects.maps.existFullScreen();
await a11y.testAppSnapshot();
});

it('displays exit full screen logo button', async () => {
await testSubjects.click('exitFullScreenModeButton');
await PageObjects.maps.enterFullScreen();
await a11y.testAppSnapshot();
});

Expand Down