-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] AIOps: Link from Explain Log Rate Spikes to Log Pattern Analysis #155121
Merged
walterra
merged 14 commits into
elastic:main
from
walterra:ml-153753-link-to-log-pattern-analysis
Apr 24, 2023
+631
−132
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5104d7c
adds action to link to log pattern analysis from explain log rate spikes
walterra 9d191c7
fix button styles
walterra 0ca7185
add log pattern analysis action to grouped table
walterra 2d9074e
fix imports
walterra 01458a8
fix tsconfig
walterra 6fee2b8
fix types
walterra 8908281
fix jest tests
walterra 0a4a0a9
Merge branch 'main' into ml-153753-link-to-log-pattern-analysis
walterra bbce6de
adds kibana sample data logs as another explain log rate spikes test …
walterra c916436
adds workflow to go from explain log rate spikes to log pattern analy…
walterra f4de6a8
fix data-test-subj in jest test
walterra 96f6d81
Merge branch 'main' into ml-153753-link-to-log-pattern-analysis
walterra a1a3d9f
Merge branch 'main' into ml-153753-link-to-log-pattern-analysis
walterra ab28bf2
tweak prop name. fix missing error handling.
walterra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
45 changes: 45 additions & 0 deletions
45
x-pack/plugins/aiops/public/application/utils/url_state.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import type * as estypes from '@elastic/elasticsearch/lib/api/typesWithBodyKey'; | ||
|
||
import type { Filter, Query } from '@kbn/es-query'; | ||
import { isPopulatedObject } from '@kbn/ml-is-populated-object'; | ||
|
||
import { SEARCH_QUERY_LANGUAGE, SearchQueryLanguage } from './search_utils'; | ||
|
||
const defaultSearchQuery = { | ||
match_all: {}, | ||
}; | ||
|
||
export interface AiOpsPageUrlState { | ||
pageKey: 'AIOPS_INDEX_VIEWER'; | ||
pageUrlState: AiOpsIndexBasedAppState; | ||
} | ||
|
||
export interface AiOpsIndexBasedAppState { | ||
searchString?: Query['query']; | ||
searchQuery?: estypes.QueryDslQueryContainer; | ||
searchQueryLanguage: SearchQueryLanguage; | ||
filters?: Filter[]; | ||
} | ||
|
||
export type AiOpsFullIndexBasedAppState = Required<AiOpsIndexBasedAppState>; | ||
|
||
export const getDefaultAiOpsListState = ( | ||
overrides?: Partial<AiOpsIndexBasedAppState> | ||
): AiOpsFullIndexBasedAppState => ({ | ||
searchString: '', | ||
searchQuery: defaultSearchQuery, | ||
searchQueryLanguage: SEARCH_QUERY_LANGUAGE.KUERY, | ||
filters: [], | ||
...overrides, | ||
}); | ||
|
||
export const isFullAiOpsListState = (arg: unknown): arg is AiOpsFullIndexBasedAppState => { | ||
return isPopulatedObject(arg, Object.keys(getDefaultAiOpsListState())); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
x-pack/plugins/aiops/public/components/spike_analysis_table/table_action_button.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import React, { type FC } from 'react'; | ||
|
||
import { EuiLink, EuiIcon, EuiText, EuiToolTip, type IconType } from '@elastic/eui'; | ||
|
||
interface TableActionButtonProps { | ||
iconType: IconType; | ||
dataTestSubjPostfix: string; | ||
isDisabled: boolean; | ||
label: string; | ||
message?: string; | ||
onClick: () => void; | ||
} | ||
|
||
export const TableActionButton: FC<TableActionButtonProps> = ({ | ||
iconType, | ||
dataTestSubjPostfix, | ||
isDisabled, | ||
label, | ||
message, | ||
onClick, | ||
}) => { | ||
const buttonContent = ( | ||
<> | ||
<EuiIcon type={iconType} css={{ marginRight: '8px' }} /> | ||
{label} | ||
</> | ||
); | ||
|
||
const unwrappedButton = !isDisabled ? ( | ||
<EuiLink | ||
data-test-subj={`aiopsTableActionButton${dataTestSubjPostfix} enabled`} | ||
onClick={onClick} | ||
color={'text'} | ||
aria-label={message} | ||
> | ||
{buttonContent} | ||
</EuiLink> | ||
) : ( | ||
<EuiText | ||
data-test-subj={`aiopsTableActionButton${dataTestSubjPostfix} disabled`} | ||
size="s" | ||
color={'subdued'} | ||
aria-label={message} | ||
css={{ fontWeight: 500 }} | ||
> | ||
{buttonContent} | ||
</EuiText> | ||
); | ||
|
||
if (message) { | ||
return <EuiToolTip content={message}>{unwrappedButton}</EuiToolTip>; | ||
} | ||
|
||
return unwrappedButton; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, maybe
tooltipText
or something similar would be a more descriptive name for this prop?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in ab28bf2.