Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search][Search Applications] Remove overview page #155098

Conversation

TattdCodeMonkey
Copy link
Contributor

Summary

Removed the search applications overview page and replaced it as the default page with the search preview page.

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.8.0 labels Apr 17, 2023
@TattdCodeMonkey TattdCodeMonkey requested a review from a team April 17, 2023 21:52
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta delete some unused translation keys, but LGTM otherwise

@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/search-apps/preview-page-default branch from 8b304c2 to 5134cbf Compare April 18, 2023 13:24
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2059 2057 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB -3.5KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

  • 💔 Build #120491 failed 8b304c2b3d43532dc3b5bbe5495fdbfd191bc41e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit e000247 into elastic:main Apr 18, 2023
@TattdCodeMonkey TattdCodeMonkey deleted the rnorris/search-apps/preview-page-default branch April 18, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants