Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix output ca_trusted_fingerprint validation message #154651

Merged

Conversation

nchaulet
Copy link
Member

Summary

Update the validation message for the output ca_trusted_fingerprint to remove the mention of base64 encoded that was not correct at all.

UI Changes

Screenshot 2023-04-10 at 9 25 35 AM

Questions

It is not easy for the users to find the info on how to generate the fingerprint should we add something directly in the UI like this?

Screenshot 2023-04-10 at 9 25 15 AM

@karenzone @insukcho what do you think?

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0 labels Apr 10, 2023
@nchaulet nchaulet self-assigned this Apr 10, 2023
@nchaulet nchaulet requested a review from a team as a code owner April 10, 2023 13:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 942.2KB 942.2KB +15.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM - I like the idea of having a better explanation of what we're expecting here too with a shell example or maybe a link to some docs. I'll let some tech writing folks weigh in on specifics.

@nchaulet nchaulet merged commit 70eb193 into elastic:main Apr 17, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 17, 2023
@nchaulet nchaulet deleted the fix-output-ca-trusted-fingerpirnt-validation branch April 17, 2023 12:52
@insukcho
Copy link

LGTM, too! Sorry for the late response. Also totally agree to add more specific guidelines in the UI. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants