Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Address react warnings for legacy table #154579

Merged
merged 3 commits into from
Apr 20, 2023
Merged

[Discover] Address react warnings for legacy table #154579

merged 3 commits into from
Apr 20, 2023

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Apr 6, 2023 •
edited by kibanamachine
Loading

Summary

This PR resolves react warnings for the legacy table:

passing undefined to `TotalDocuments` during loading 
ract_devtools_backend.js:2655 Warning: Failed prop type: The prop `value` is marked as required in `FormattedNumber`, but its value is `undefined`.
    at FormattedNumber (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149935:5)
    at TotalDocuments (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:70:3)
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at EuiFlexItem (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at EuiFlexItem (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23
    at DocTableEmbeddable (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:309:109)
    at PseudoLocaleWrapper (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)
    at IntlProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)
    at I18nProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)
    at DiscoverDocTableEmbeddable (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:235:26)
    at SavedSearchEmbeddableComponent (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:976:3)
    at Provider (http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:1794:15)
    at CurrentEuiBreakpointProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161492:23)
    at EuiThemeProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:166432:22)
    at EuiCacheProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:138902:20)
    at EuiProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:139002:25)
    at KibanaThemeProvider (http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:4625:3)
    at PseudoLocaleWrapper (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)
    at IntlProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)
    at I18nProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)
o
non unique keys for table headers and columns in SQL mode 
ract_devtools_backend.js:2655 Warning: Encountered two children with the same key, `order_date`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
    at tr
    at TableHeader (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.3.js:3956:3)
    at thead
    at table
    at DocTableInfiniteContent (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:15565:3)
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.3.js:4710:3
    at DocTableInfinite (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:15613:79)
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at EuiFlexItem (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)
    at DiscoverDocumentsComponent (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:6758:3)
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23
    at DiscoverMainContent (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:7485:3)
    at InPortal (http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:980:28)
    at UnifiedHistogramLayout (http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:3694:3)
    at http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:3019:95
    at Suspense
    at EuiErrorBoundary (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108416:81)
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at DiscoverHistogramLayout (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:6956:3)
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at EuiPanel (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:136743:23)
    at EuiPageContent_Deprecated (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133907:31)
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at EuiFlexItem (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at EuiPageBody (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133756:23)
    at div
    at http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
    at EuiPage (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133610:23)
    at DiscoverLayout (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:7173:3)
    at DiscoverMainProvider (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:14340:3)
    at DiscoverMainApp (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:12539:5)
    at DiscoverMainRoute (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:12703:86)
    at Route (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:361914:29)
    at Route (http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:3677:3)
    at Switch (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:362120:29)
    at Router (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:361543:30)
    at EuiErrorBoundary (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108416:81)
    at Provider (http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:1794:15)
    at CurrentEuiBreakpointProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161492:23)
    at EuiThemeProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:166432:22)
    at EuiCacheProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:138902:20)
    at EuiProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:139002:25)
    at KibanaThemeProvider (http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:4625:3)
    at PseudoLocaleWrapper (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)
    at IntlProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)
    at I18nProvider (http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)
o

The one regarding array keys is interesting: time field column is rendered twice in the legacy table (as the first column and later on again) in SQL mode. We could consider removing this duplication in columns but this would become a breaking change to the existing behaviour, no? So I went with updating the key for now.

For testing:

  • switch to legacy table via Advanced Settings
    • add a saved search to Dashboard
    • check SQL mode on Discover

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Apr 6, 2023
@jughosta jughosta self-assigned this Apr 6, 2023
@jughosta jughosta marked this pull request as ready for review April 18, 2023 12:20
@jughosta jughosta requested a review from a team as a code owner April 18, 2023 12:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 398.1KB 398.1KB +20.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

davismcphee
davismcphee approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested locally, not seeing the warnings anymore. LGTM, thanks for the cleanup!

@jughosta jughosta merged commit d079fbb into elastic:main Apr 20, 2023
@jughosta jughosta deleted the address-legacy-table-warnings branch April 20, 2023 07:12
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.7 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 154579

Questions ?

Please refer to the Backport tool documentation

@jughosta jughosta mentioned this pull request Apr 20, 2023
Merged
jughosta added a commit to jughosta/kibana that referenced this pull request Apr 20, 2023
@jughosta
[Discover] Address react warnings for legacy table (elastic#154579)
bb49d79 
## Summary

This PR resolves react warnings for the legacy table:
<details><summary>passing undefined to `TotalDocuments` during
loading</summary>
<pre>
ract_devtools_backend.js:2655 Warning: Failed prop type: The prop
`value` is marked as required in `FormattedNumber`, but its value is
`undefined`.
at FormattedNumber
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149935:5)
at TotalDocuments
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:70:3)
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at EuiFlexItem
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at EuiFlexItem
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23
at DocTableEmbeddable
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:309:109)
at PseudoLocaleWrapper
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)
at IntlProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)
at I18nProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)
at DiscoverDocTableEmbeddable
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:235:26)
at SavedSearchEmbeddableComponent
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:976:3)
at Provider
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:1794:15)
at CurrentEuiBreakpointProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161492:23)
at EuiThemeProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:166432:22)
at EuiCacheProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:138902:20)
at EuiProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:139002:25)
at KibanaThemeProvider
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:4625:3)
at PseudoLocaleWrapper
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)
at IntlProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)
at I18nProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)
o
</pre>
</details>

<details><summary>non unique keys for table headers and columns in SQL
mode</summary>
<pre>
ract_devtools_backend.js:2655 Warning: Encountered two children with the
same key, `order_date`. Keys should be unique so that components
maintain their identity across updates. Non-unique keys may cause
children to be duplicated and/or omitted — the behavior is unsupported
and could change in a future version.
    at tr
at TableHeader
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.3.js:3956:3)
    at thead
    at table
at DocTableInfiniteContent
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:15565:3)
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.3.js:4710:3
at DocTableInfinite
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:15613:79)
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at EuiFlexItem
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)
at DiscoverDocumentsComponent
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:6758:3)
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23
at DiscoverMainContent
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:7485:3)
at InPortal
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:980:28)
at UnifiedHistogramLayout
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:3694:3)
at
http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:3019:95
    at Suspense
at EuiErrorBoundary
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108416:81)
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at DiscoverHistogramLayout
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:6956:3)
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at EuiPanel
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:136743:23)
at EuiPageContent_Deprecated
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133907:31)
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at EuiFlexItem
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at EuiPageBody
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133756:23)
    at div
at
http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73
at EuiPage
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133610:23)
at DiscoverLayout
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:7173:3)
at DiscoverMainProvider
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:14340:3)
at DiscoverMainApp
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:12539:5)
at DiscoverMainRoute
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:12703:86)
at Route
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:361914:29)
at Route
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:3677:3)
at Switch
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:362120:29)
at Router
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:361543:30)
at EuiErrorBoundary
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108416:81)
at Provider
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:1794:15)
at CurrentEuiBreakpointProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161492:23)
at EuiThemeProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:166432:22)
at EuiCacheProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:138902:20)
at EuiProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:139002:25)
at KibanaThemeProvider
(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:4625:3)
at PseudoLocaleWrapper
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)
at IntlProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)
at I18nProvider
(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)
o
</pre>
</details>

The one regarding array keys is interesting: time field column is
rendered twice in the legacy table (as the first column and later on
again) in SQL mode. We could consider removing this duplication in
columns but this would become a breaking change to the existing
behaviour, no? So I went with updating the key for now.

For testing:
- switch to legacy table via Advanced Settings
  - add a saved search to Dashboard
  - check SQL mode on Discover

(cherry picked from commit d079fbb)

# Conflicts:
#	src/plugins/discover/public/embeddable/saved_search_grid.tsx
jughosta added a commit that referenced this pull request Apr 20, 2023
@jughosta
[8.7] [Discover] Address react warnings for legacy table (#154579) (#…
d07697d 
…155345)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Discover] Address react warnings for legacy table
(#154579)](#154579)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-20T07:11:59Z","message":"[Discover]
Address react warnings for legacy table (#154579)\n\n##
Summary\r\n\r\nThis PR resolves react warnings for the legacy
table:\r\n<details><summary>passing undefined to `TotalDocuments`
during\r\nloading</summary>\r\n<pre>\r\nract_devtools_backend.js:2655
Warning: Failed prop type: The prop\r\n`value` is marked as required in
`FormattedNumber`, but its value is\r\n`undefined`.\r\nat
FormattedNumber\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149935:5)\r\nat
TotalDocuments\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:70:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\nat
DocTableEmbeddable\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:309:109)\r\nat
PseudoLocaleWrapper\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)\r\nat
IntlProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)\r\nat
I18nProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)\r\nat
DiscoverDocTableEmbeddable\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:235:26)\r\nat
SavedSearchEmbeddableComponent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:976:3)\r\nat
Provider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:1794:15)\r\nat
CurrentEuiBreakpointProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161492:23)\r\nat
EuiThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:166432:22)\r\nat
EuiCacheProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:138902:20)\r\nat
EuiProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:139002:25)\r\nat
KibanaThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:4625:3)\r\nat
PseudoLocaleWrapper\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)\r\nat
IntlProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)\r\nat
I18nProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)\r\no\r\n</pre>\r\n</details>\r\n\r\n<details><summary>non
unique keys for table headers and columns in
SQL\r\nmode</summary>\r\n<pre>\r\nract_devtools_backend.js:2655 Warning:
Encountered two children with the\r\nsame key, `order_date`. Keys should
be unique so that components\r\nmaintain their identity across updates.
Non-unique keys may cause\r\nchildren to be duplicated and/or omitted —
the behavior is unsupported\r\nand could change in a future version.\r\n
at tr\r\nat
TableHeader\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.3.js:3956:3)\r\n
at thead\r\n at table\r\nat
DocTableInfiniteContent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:15565:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.3.js:4710:3\r\nat
DocTableInfinite\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:15613:79)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\nat
DiscoverDocumentsComponent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:6758:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\nat
DiscoverMainContent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:7485:3)\r\nat
InPortal\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:980:28)\r\nat
UnifiedHistogramLayout\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:3694:3)\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:3019:95\r\n
at Suspense\r\nat
EuiErrorBoundary\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108416:81)\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
DiscoverHistogramLayout\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:6956:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiPanel\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:136743:23)\r\nat
EuiPageContent_Deprecated\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133907:31)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiPageBody\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133756:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiPage\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133610:23)\r\nat
DiscoverLayout\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:7173:3)\r\nat
DiscoverMainProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:14340:3)\r\nat
DiscoverMainApp\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:12539:5)\r\nat
DiscoverMainRoute\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:12703:86)\r\nat
Route\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:361914:29)\r\nat
Route\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:3677:3)\r\nat
Switch\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:362120:29)\r\nat
Router\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:361543:30)\r\nat
EuiErrorBoundary\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108416:81)\r\nat
Provider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:1794:15)\r\nat
CurrentEuiBreakpointProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161492:23)\r\nat
EuiThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:166432:22)\r\nat
EuiCacheProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:138902:20)\r\nat
EuiProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:139002:25)\r\nat
KibanaThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:4625:3)\r\nat
PseudoLocaleWrapper\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)\r\nat
IntlProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)\r\nat
I18nProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)\r\no\r\n</pre>\r\n</details>\r\n\r\nThe
one regarding array keys is interesting: time field column
is\r\nrendered twice in the legacy table (as the first column and later
on\r\nagain) in SQL mode. We could consider removing this duplication
in\r\ncolumns but this would become a breaking change to the
existing\r\nbehaviour, no? So I went with updating the key for
now.\r\n\r\nFor testing:\r\n- switch to legacy table via Advanced
Settings\r\n - add a saved search to Dashboard\r\n - check SQL mode on
Discover","sha":"d079fbb0c80fa124ee8499887d146663463581c6","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.8.0"],"number":154579,"url":"https://github.com/elastic/kibana/pull/154579","mergeCommit":{"message":"[Discover]
Address react warnings for legacy table (#154579)\n\n##
Summary\r\n\r\nThis PR resolves react warnings for the legacy
table:\r\n<details><summary>passing undefined to `TotalDocuments`
during\r\nloading</summary>\r\n<pre>\r\nract_devtools_backend.js:2655
Warning: Failed prop type: The prop\r\n`value` is marked as required in
`FormattedNumber`, but its value is\r\n`undefined`.\r\nat
FormattedNumber\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149935:5)\r\nat
TotalDocuments\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:70:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\nat
DocTableEmbeddable\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:309:109)\r\nat
PseudoLocaleWrapper\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)\r\nat
IntlProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)\r\nat
I18nProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)\r\nat
DiscoverDocTableEmbeddable\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:235:26)\r\nat
SavedSearchEmbeddableComponent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:976:3)\r\nat
Provider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:1794:15)\r\nat
CurrentEuiBreakpointProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161492:23)\r\nat
EuiThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:166432:22)\r\nat
EuiCacheProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:138902:20)\r\nat
EuiProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:139002:25)\r\nat
KibanaThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:4625:3)\r\nat
PseudoLocaleWrapper\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)\r\nat
IntlProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)\r\nat
I18nProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)\r\no\r\n</pre>\r\n</details>\r\n\r\n<details><summary>non
unique keys for table headers and columns in
SQL\r\nmode</summary>\r\n<pre>\r\nract_devtools_backend.js:2655 Warning:
Encountered two children with the\r\nsame key, `order_date`. Keys should
be unique so that components\r\nmaintain their identity across updates.
Non-unique keys may cause\r\nchildren to be duplicated and/or omitted —
the behavior is unsupported\r\nand could change in a future version.\r\n
at tr\r\nat
TableHeader\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.3.js:3956:3)\r\n
at thead\r\n at table\r\nat
DocTableInfiniteContent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:15565:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.3.js:4710:3\r\nat
DocTableInfinite\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:15613:79)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\nat
DiscoverDocumentsComponent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:6758:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\nat
DiscoverMainContent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:7485:3)\r\nat
InPortal\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:980:28)\r\nat
UnifiedHistogramLayout\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:3694:3)\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:3019:95\r\n
at Suspense\r\nat
EuiErrorBoundary\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108416:81)\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
DiscoverHistogramLayout\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:6956:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiPanel\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:136743:23)\r\nat
EuiPageContent_Deprecated\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133907:31)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiPageBody\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133756:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiPage\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133610:23)\r\nat
DiscoverLayout\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:7173:3)\r\nat
DiscoverMainProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:14340:3)\r\nat
DiscoverMainApp\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:12539:5)\r\nat
DiscoverMainRoute\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:12703:86)\r\nat
Route\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:361914:29)\r\nat
Route\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:3677:3)\r\nat
Switch\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:362120:29)\r\nat
Router\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:361543:30)\r\nat
EuiErrorBoundary\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108416:81)\r\nat
Provider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:1794:15)\r\nat
CurrentEuiBreakpointProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161492:23)\r\nat
EuiThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:166432:22)\r\nat
EuiCacheProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:138902:20)\r\nat
EuiProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:139002:25)\r\nat
KibanaThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:4625:3)\r\nat
PseudoLocaleWrapper\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)\r\nat
IntlProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)\r\nat
I18nProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)\r\no\r\n</pre>\r\n</details>\r\n\r\nThe
one regarding array keys is interesting: time field column
is\r\nrendered twice in the legacy table (as the first column and later
on\r\nagain) in SQL mode. We could consider removing this duplication
in\r\ncolumns but this would become a breaking change to the
existing\r\nbehaviour, no? So I went with updating the key for
now.\r\n\r\nFor testing:\r\n- switch to legacy table via Advanced
Settings\r\n - add a saved search to Dashboard\r\n - check SQL mode on
Discover","sha":"d079fbb0c80fa124ee8499887d146663463581c6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/154579","number":154579,"mergeCommit":{"message":"[Discover]
Address react warnings for legacy table (#154579)\n\n##
Summary\r\n\r\nThis PR resolves react warnings for the legacy
table:\r\n<details><summary>passing undefined to `TotalDocuments`
during\r\nloading</summary>\r\n<pre>\r\nract_devtools_backend.js:2655
Warning: Failed prop type: The prop\r\n`value` is marked as required in
`FormattedNumber`, but its value is\r\n`undefined`.\r\nat
FormattedNumber\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149935:5)\r\nat
TotalDocuments\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:70:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\nat
DocTableEmbeddable\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:309:109)\r\nat
PseudoLocaleWrapper\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)\r\nat
IntlProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)\r\nat
I18nProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)\r\nat
DiscoverDocTableEmbeddable\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:235:26)\r\nat
SavedSearchEmbeddableComponent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.7.js:976:3)\r\nat
Provider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:1794:15)\r\nat
CurrentEuiBreakpointProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161492:23)\r\nat
EuiThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:166432:22)\r\nat
EuiCacheProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:138902:20)\r\nat
EuiProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:139002:25)\r\nat
KibanaThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:4625:3)\r\nat
PseudoLocaleWrapper\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)\r\nat
IntlProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)\r\nat
I18nProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)\r\no\r\n</pre>\r\n</details>\r\n\r\n<details><summary>non
unique keys for table headers and columns in
SQL\r\nmode</summary>\r\n<pre>\r\nract_devtools_backend.js:2655 Warning:
Encountered two children with the\r\nsame key, `order_date`. Keys should
be unique so that components\r\nmaintain their identity across updates.
Non-unique keys may cause\r\nchildren to be duplicated and/or omitted —
the behavior is unsupported\r\nand could change in a future version.\r\n
at tr\r\nat
TableHeader\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.3.js:3956:3)\r\n
at thead\r\n at table\r\nat
DocTableInfiniteContent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:15565:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.3.js:4710:3\r\nat
DocTableInfinite\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:15613:79)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\nat
DiscoverDocumentsComponent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:6758:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\nat
DiscoverMainContent\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:7485:3)\r\nat
InPortal\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:980:28)\r\nat
UnifiedHistogramLayout\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:3694:3)\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/plugin/unifiedHistogram/1.0.0/unifiedHistogram.chunk.0.js:3019:95\r\n
at Suspense\r\nat
EuiErrorBoundary\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108416:81)\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
DiscoverHistogramLayout\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:6956:3)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiPanel\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:136743:23)\r\nat
EuiPageContent_Deprecated\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133907:31)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiFlexItem\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109977:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109752:23\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiPageBody\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133756:23)\r\n
at
div\r\nat\r\nhttp://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:170360:73\r\nat
EuiPage\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133610:23)\r\nat
DiscoverLayout\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:7173:3)\r\nat
DiscoverMainProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:14340:3)\r\nat
DiscoverMainApp\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:12539:5)\r\nat
DiscoverMainRoute\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:12703:86)\r\nat
Route\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:361914:29)\r\nat
Route\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/discover/1.0.0/discover.chunk.6.js:3677:3)\r\nat
Switch\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:362120:29)\r\nat
Router\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:361543:30)\r\nat
EuiErrorBoundary\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108416:81)\r\nat
Provider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:1794:15)\r\nat
CurrentEuiBreakpointProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:161492:23)\r\nat
EuiThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:166432:22)\r\nat
EuiCacheProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:138902:20)\r\nat
EuiProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:139002:25)\r\nat
KibanaThemeProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:4625:3)\r\nat
PseudoLocaleWrapper\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14199:5)\r\nat
IntlProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:149454:5)\r\nat
I18nProvider\r\n(http://localhost:5601/rzv/9007199254740991/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:14130:3)\r\no\r\n</pre>\r\n</details>\r\n\r\nThe
one regarding array keys is interesting: time field column
is\r\nrendered twice in the legacy table (as the first column and later
on\r\nagain) in SQL mode. We could consider removing this duplication
in\r\ncolumns but this would become a breaking change to the
existing\r\nbehaviour, no? So I went with updating the key for
now.\r\n\r\nFor testing:\r\n- switch to legacy table via Advanced
Settings\r\n - add a saved search to Dashboard\r\n - check SQL mode on
Discover","sha":"d079fbb0c80fa124ee8499887d146663463581c6"}}]}]
BACKPORT-->
rylnd added a commit that referenced this pull request Apr 21, 2023
@rylnd
Merge branch '8.7' into risk_score_api_8.7
c70c7ea 
* 8.7: (93 commits)
  [8.7] [Controls] Use EUI Selectable for Field search (#151231) (#155454)
  [8.7] [Synthetics] Fix  performance breakdown link from error details page (#155393) (#155427)
  [8.7] [DOCS] Remove or move book-scoped attributes (#155210) (#155426)
  [8.7] [Synthetics] add default email recovery message (#154862) (#155418)
  [8.7] [Uptime] Add both both ip filters for view host in uptime location for host and monitor (#155382) (#155399)
  [8.7] Setup Node.js environment before instrumenting Kibana with APM. (#155063) (#155300)
  [8.7] [Discover] Address react warnings for legacy table (#154579) (#155345)
  [8.7] [Fleet] Fix logs useless rerender (#155305) (#155310)
  [8.7] [kbn-failed-test-reporter-cli] truncate report message to fix github api call failure (#155141) (#155286)
  [8.7][APM] Fleet migration support for bundled APM package (#153159)  (#155281)
  [8.7] [Enterprise Search] Fix Connector scheduling show week information correctly (#155191) (#155227)
  [8.7] [Synthetics] Fix pending count in case of location filtering (#155200) (#155225)
  [8.7] [Controls] Add Expensive Queries Fallback (#155082) (#155189)
  [8.7] [data view field editor] Runtime field code editor - move state out of controller (#155107) (#155150)
  [8.7] [FullStory] Update snippet (#153570) (#155138)
  [8.7] [Security Solution][Exceptions] - Fix exception operator logic when mapping conflict (#155071) (#155094)
  [DOCS] Adds 8.7.1 release notes (#154844)
  [8.7] Sync bundled packages with Package Storage (#155042)
  [APM] plugin description (#154811)
  Update api.asciidoc (#155021)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.1 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jughosta @elasticmachine @kibana-ci @kibanamachine @davismcphee