[AO] - Add rule-specific fields, threshold, and reuse alert details package components #154569

fkanout · 2023-04-06T14:46:17Z

Summary

It fixes #153675, fixes #153567, fixes #153946, fixes #154845

apmmachine · 2023-04-06T14:46:30Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…fix'

elasticmachine · 2023-04-12T16:24:20Z

Pinging @elastic/actionable-observability (Team: Actionable Observability)

fkanout · 2023-04-13T09:36:07Z

x-pack/plugins/infra/public/hooks/use_alerts_history.ts

Basically, I applied what was suggested here #153930 (comment)
And in another PR will move it to the Observability

...k/plugins/infra/public/alerting/log_threshold/components/alert_details_app_section/index.tsx

tonyghiani

LGTM, I left some non-blocking nits, thanks for the changes on the custom hook!

kibana-ci · 2023-04-13T12:40:03Z

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #4 / cases security and spaces enabled: basic Common bulk_create_attachments creation should bulk create multiple attachments
[job] [logs] FTR Configs #23 / cases security and spaces enabled: trial Common bulk_create_attachments alert filtering should create a new attachment without alerts attached to the case on the same request
[job] [logs] FTR Configs #23 / cases security and spaces enabled: trial Common bulk_create_attachments creation should bulk create multiple attachments

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	1328	1327	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	2.0MB	2.0MB	+3.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	89.7KB	90.0KB	+277.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	433	436	+3

Total ESLint disabled count

id	before	after	diff
`securitySolution`	512	515	+3

History

💚 Build #119489 succeeded ecbdcaa
💔 Build #119397 failed f271222
💔 Build #119362 failed 7a08c9b
💔 Build #119339 failed 946545d
💔 Build #119091 failed 4af0f0a
💔 Build #118988 failed 67524dd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @fkanout

maryam-saeidi · 2023-04-20T09:38:08Z

...k/plugins/infra/public/alerting/log_threshold/components/alert_details_app_section/index.tsx

+                  <EuiSpacer size="s" />
+                  {chartCriterion.comparator && (
+                    <Threshold
+                      title={`Threshold breached`}


@fkanout Shouldn't we translate this text?

maryam-saeidi · 2023-04-20T10:13:15Z

x-pack/plugins/infra/public/alerting/common/components/threshold.tsx

@@ -19,7 +19,7 @@ export interface ChartProps {

 export interface Props {
  chartProps: ChartProps;
-  comparator: Comparator;
+  comparator: Comparator | string;


@fkanout Why do we need to add string type here?

maryam-saeidi · 2023-04-20T13:59:02Z

...k/plugins/infra/public/alerting/log_threshold/components/alert_details_app_section/index.tsx

+                  {chartCriterion.comparator && (
+                    <Threshold
+                      title={`Threshold breached`}
+                      chartProps={{ theme, baseTheme: LIGHT_THEME }}


How does it work with only LIGHT_THEME as a base theme?

Previously, I provided it like this: https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability/public/pages/rule_details/index.tsx#L97

fkanout added 2 commits April 4, 2023 17:07

Remove unwanted prop

fe877ad

Add rule specific fields to the rule summary and update hook

e2a393c

fkanout added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Apr 6, 2023

fkanout self-assigned this Apr 6, 2023

fkanout and others added 5 commits April 6, 2023 16:47

Merge branch 'main' into 153675-add-rule-fields-alert-summary

10e6c39

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

35ce4d7

…fix'

Add threshold component

67524dd

Update threshold

8990ca7

Add the the ability to hide the text to mach the design

f9e8135

fkanout changed the title ~~[AO] - Add rule-specific fields to alert summary for the Logs Alert Details page~~ [AO] - Add rule-specific fields, and threshold Apr 11, 2023

fkanout added 4 commits April 11, 2023 17:41

Merge branch 'main' into 153675-add-rule-fields-alert-summary

7af2057

Update key

3b00c18

use i18n for text concatenation

9f79a09

Merge branch 'main' into 153675-add-rule-fields-alert-summary

4af0f0a

fkanout added the release_note:skip Skip the PR/issue when compiling release notes label Apr 11, 2023

fkanout added 7 commits April 12, 2023 13:12

Cleaner duration

0840239

when executionTimeRange remove additional text

946545d

Update text

8efc8fa

Merge branch 'main' into 153675-add-rule-fields-alert-summary

7a08c9b

Update the comparator

f271222

use alert details package

119e024

Merge branch 'main' into 153675-add-rule-fields-alert-summary

ecbdcaa

fkanout marked this pull request as ready for review April 12, 2023 16:24

fkanout requested a review from a team as a code owner April 12, 2023 16:24

fkanout changed the title ~~[AO] - Add rule-specific fields, and threshold~~ [AO] - Add rule-specific fields, threshold, and optim Apr 12, 2023

fkanout changed the title ~~[AO] - Add rule-specific fields, threshold, and optim~~ [AO] - Add rule-specific fields, threshold, and reuse alert details package components Apr 12, 2023

fkanout commented Apr 13, 2023

View reviewed changes

tonyghiani reviewed Apr 13, 2023

View reviewed changes

...k/plugins/infra/public/alerting/log_threshold/components/alert_details_app_section/index.tsx Outdated Show resolved Hide resolved

tonyghiani reviewed Apr 13, 2023

View reviewed changes

...k/plugins/infra/public/alerting/log_threshold/components/alert_details_app_section/index.tsx Outdated Show resolved Hide resolved

tonyghiani approved these changes Apr 13, 2023

View reviewed changes

fkanout added 2 commits April 13, 2023 13:01

code review

125eebd

code review

3334bad

fkanout enabled auto-merge (squash) April 13, 2023 11:52

fkanout merged commit 89e8d03 into elastic:main Apr 13, 2023

kibanamachine added the backport:skip This commit does not require backporting label Apr 13, 2023

maryam-saeidi reviewed Apr 20, 2023

View reviewed changes

elasticmachine unassigned fkanout Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AO] - Add rule-specific fields, threshold, and reuse alert details package components #154569

[AO] - Add rule-specific fields, threshold, and reuse alert details package components #154569

fkanout commented Apr 6, 2023 •

edited

Loading

apmmachine commented Apr 6, 2023

elasticmachine commented Apr 12, 2023

fkanout Apr 13, 2023

tonyghiani left a comment

kibana-ci commented Apr 13, 2023

ESLint disabled line counts

Total ESLint disabled count

maryam-saeidi Apr 20, 2023

maryam-saeidi Apr 20, 2023

maryam-saeidi Apr 20, 2023 •

edited

Loading

[AO] - Add rule-specific fields, threshold, and reuse alert details package components #154569

[AO] - Add rule-specific fields, threshold, and reuse alert details package components #154569

Conversation

fkanout commented Apr 6, 2023 • edited Loading

Summary

apmmachine commented Apr 6, 2023

🤖 GitHub comments

elasticmachine commented Apr 12, 2023

fkanout Apr 13, 2023

Choose a reason for hiding this comment

tonyghiani left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 13, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

maryam-saeidi Apr 20, 2023

Choose a reason for hiding this comment

maryam-saeidi Apr 20, 2023

Choose a reason for hiding this comment

maryam-saeidi Apr 20, 2023 • edited Loading

Choose a reason for hiding this comment

fkanout commented Apr 6, 2023 •

edited

Loading

maryam-saeidi Apr 20, 2023 •

edited

Loading