-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] Fix DNS histogram query #154548
Conversation
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
x-pack/plugins/security_solution/public/common/components/matrix_histogram/index.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for catching this and for the thorough tests!
Summary
This fix below query issues within DNS histogram:
1. The terms aggregates field should be
dns.question.regustered_domain
insteaddns.question.domain
Steps to verify:
dns.question.regustered_domain
Known issue:
#154533
2. It didn't respect
is PTR record included
flagSteps to verify:
include PTR record
Screen.Recording.2023-04-06.at.12.40.56.mov
3. It didn't respect
is PTR record included
when feature flagchartEmbeddablesEnabled: is false
Steps to verify:
include PTR record
Screen.Recording.2023-04-06.at.16.04.54.mov
After:
Screen.Recording.2023-04-06.at.12.30.40.mov
Checklist
Delete any items that are not applicable to this PR.