-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split .kibana system index into multiple indices #154444
Split .kibana system index into multiple indices #154444
Conversation
…-ref HEAD~1..HEAD --fix'
…1-split-multiple-indices-relocate
…1-split-multiple-indices-relocate
…1-split-multiple-indices-relocate
@@ -65,6 +65,7 @@ export function mergeMigrationMappingPropertyHashes( | |||
return { | |||
...targetMappings, | |||
_meta: { | |||
...targetMappings._meta, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no unit tests for this mergeMigrationMappingPropertyHashes
helper. We should add some (and assert the behavior of this change/fix)
Should this be done in the current PR or on the 'upstream' one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do it on the upstream PR.
But first I wanted to check whether this mergeMigrationMappingPropertyHashes
operation is still necessary.
If we want to use these hashes as a basis to construct the indexTypesMap
, I'm afraid the merge can be problematic. @rudolf WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use these in checkTargetMappings
as a way to determine if mappings are up to date. If we don't merge the _meta it means there could be plugins which have applied some mappings that we don't know about. This would cause us to go to UPDATE_TARGET_MAPPINGS_PROPERTIES
which would be unecessary but not a problem. So I don't see an obvious problem right now.
…ltiple-indices-relocate
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Saved Objects .kibana field count
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Replaced by #154888 |
Part of #104081
Depends on #154151
First attempt is to move all 'cases*' saved objects into a separate
.kibana_cases
index.esArchiver (along with all FTR that use it) has proven a worthy enemy of this initiative, as it relies on the fact that there are only two system indices:
.kibana
and.kibana_task_manager
.