[Cases] Delete alerts when deleting all comments #154202
Conversation
cnasikas
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
| @@ -387,35 +386,6 @@ export default ({ getService }: FtrProviderContext): void => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should delete multiple comments from the appropriate owner', async () => { | |||
There was a problem hiding this comment.
I moved all tests about deleteAllComments to x-pack/test/cases_api_integration/security_and_spaces/tests/common/comments/delete_comments.ts
There was a problem hiding this comment.
I preferred to create another file for the delete all cases comments API even though the code is very similar to the delete comment API. If you think otherwise let me know.
| describe('alerts', () => { | ||
| type Alerts = Array<{ _id: string; _index: string }>; | ||
|
|
||
| const createCaseAttachAlertAndDeleteAlert = async ({ |
There was a problem hiding this comment.
I believe this is the same function as in delete_comment.ts could we move it to a common place and use it in both files?
| }); | ||
| }); | ||
|
|
||
| describe('alerts', () => { |
There was a problem hiding this comment.
If it's not too painful could we have a test that deletes all comments for a case that has some alerts and other comments?
And could we also add an expect that ensures all comments are removed (like delete comments, then do a find and make sure there are no comments for the case or something).
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @cnasikas |
kibanamachine
added
v8.8.0
backport:skip
Summary
This PR remove the case id from the alerts when deleting all cases comments
Checklist
Delete any items that are not applicable to this PR.
For maintainers