Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect app/observability/exploratory-view to app/exploratory-view #153941

Conversation

CoenWarmer
Copy link
Contributor

Resolves #153940

📝 Summary

Now that the Exploratory View route inside the Observability app has been copied into its own separate application (#153830), we can redirect users from the Exploratory View component in the Obs app to Exploratory View application.

✅ Acceptance Criteria

  • When navigating to /app/observability/exploratory-view, the Observability app should redirect to /app/exploratory-view. Including search parameters!

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Mar 29, 2023
@CoenWarmer CoenWarmer requested a review from a team as a code owner March 29, 2023 13:01
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoenWarmer CoenWarmer enabled auto-merge (squash) March 29, 2023 13:28
@CoenWarmer CoenWarmer requested a review from a team as a code owner March 29, 2023 13:58
@CoenWarmer CoenWarmer force-pushed the chore/153940-redirect-users-from-obs-exploratory-view-to-app-exploratory-view branch from 1085982 to 2e6936f Compare March 30, 2023 06:31
@CoenWarmer CoenWarmer force-pushed the chore/153940-redirect-users-from-obs-exploratory-view-to-app-exploratory-view branch from 359e538 to 003984e Compare March 30, 2023 08:57
@CoenWarmer CoenWarmer removed the request for review from a team March 30, 2023 08:57
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #53 / dashboard drilldowns Dashboard to dashboard drilldown Create & use drilldowns test dashboard to dashboard drilldown with controls creates filter pills representing controls selections

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 515 514 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +5.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 89.2KB 89.2KB -45.0B
Unknown metric groups

async chunk count

id before after diff
observability 19 17 -2

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

  • 💔 Build #116623 failed 359e538ff1fee2b139d6ab2ee74d25042871400e
  • 💔 Build #116620 failed 2e6936fab08b204b505b71d27b8f7672be492208
  • 💚 Build #116572 succeeded 1085982c82de590e39cfc125fc5ba6f2e5a5208a
  • 💔 Build #116421 failed 4aedb98e09398efccbef89930eafc2a132cb281c
  • 💔 Build #116405 failed ccfe300116977c3718651ea07e4def4ff32bc702

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit e0e0b27 into elastic:main Mar 30, 2023
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability] Redirect users from app/observability/exploratory-view to app/exploratory-view
6 participants