-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Removing counter fields from wizards #153639
[ML] Removing counter fields from wizards #153639
Conversation
Pinging @elastic/ml-ui (:ml) |
Not sure if this is out of scope of this PR, but we should add this logic for the histogram fetching as well? Running into this error when using the DFA wizard: For outlier detection, should we disable counter fields? Currenty, including them will yield a validation error. Screen.Recording.2023-03-28.at.09.56.28.mov |
@qn895 I'm not able to reproduce these errors, the counter field never present for me? |
@qn895 I've pushed an update which cleans up the code a bit and removes the errors thrown when loading the histograms. |
Tested latest changes and LGTM 🎉 Seeing counter fields in the included fields but I suppose that would be fixed when elastic/elasticsearch#94691 is addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes and LGTM.
If / when Elasticsearch includes supported aggregations in the field caps api response (see elastic/elasticsearch#93884) we could look to allow certain aggregations to be used in the wizards for counter
fields.
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Further improvements to the anomaly detection and data frame analysts wizards to ensure counter fields cannot be selected when configuring a new job.
Adds a
counter
flag to thenew_job_caps
response which is used to remove counter fields from dropdowns in the DFA and advanced AD wizards.The outlier detection wizard still has an issue caused by the call to the
_explain
endpoint. This needs to be fixed in elasticsearch elastic/elasticsearch#94691