Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FullStory] Update snippet #153570

Merged
merged 3 commits into from
Apr 18, 2023
Merged

[FullStory] Update snippet #153570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0385dd
[FullStory] Update snippet
afharo Mar 23, 2023
7370ee2
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Mar 23, 2023
6575354
Merge branch 'main' into fullstory/update-snippet
kibanamachine Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions NOTICE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,9 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

---
This code is part of the Services provided by FullStory, Inc. For license information, please refer to https://www.fullstory.com/legal/terms-and-conditions/.
Portions of this code are licensed separately and can be found in https://edge.fullstory.com/s/fs.js.LICENSE.txt
This code is part of the Services provided by FullStory, Inc. For license information, please refer to https://www.fullstory.com/legal/terms-and-conditions/
Portions of this code are licensed under the following license:
For license information please see fs.js.LICENSE.txt

---
This product bundles [email protected] which is available under a
Expand Down
2 changes: 1 addition & 1 deletion packages/analytics/shippers/fullstory/src/load_snippet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export interface FullStorySnippetConfig {
}

export function loadSnippet({
scriptUrl = 'edge.fullstory.com/s/fs.js',
scriptUrl = 'https://edge.fullstory.com/s/fs.js',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that it wouldn't load correctly without the https:// if scriptUrl is not provided (but Kibana does provide it, so it's more for the sake of correctness rather than anything else).

fullStoryOrgId,
host = 'fullstory.com',
namespace = 'FS',
Expand Down
7 changes: 4 additions & 3 deletions x-pack/plugins/cloud_integrations/cloud_full_story/server/assets/fullstory_library.js
View file
Open in desktop

Large diffs are not rendered by default.